Skip to content

Backport fix of react-native run-ios in Xcode 10.2 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Backport fix of react-native run-ios in Xcode 10.2 #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions local-cli/runIOS/findMatchingSimulator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,21 @@ function findMatchingSimulator(simulators, simulatorName) {
}
const devices = simulators.devices;
var match;
for (let version in devices) {
for (const versionDescriptor in devices) {
const device = devices[versionDescriptor];
let version = versionDescriptor;

if ((/^com\.apple\.CoreSimulator\.SimRuntime\./g).test(version)) {
// Transform "com.apple.CoreSimulator.SimRuntime.iOS-12-2" into "iOS 12.2"
version = version.replace(/^com\.apple\.CoreSimulator\.SimRuntime\.([^-]+)-([^-]+)-([^-]+)$/g, '$1 $2.$3');
}

// Making sure the version of the simulator is an iOS or tvOS (Removes Apple Watch, etc)
if (!version.startsWith('iOS') && !version.startsWith('tvOS')) {
continue;
}
for (let i in devices[version]) {
let simulator = devices[version][i];
for (const i in device) {
const simulator = device[i];
// Skipping non-available simulator
if (simulator.availability !== '(available)') {
continue;
Expand Down