Skip to content

Revert performance monitor change #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Revert performance monitor change #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
033db27
Revert performance monitor change
alanjhughes Sep 27, 2024
a3d37e1
fix indent
alanjhughes Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/react-native/React/CoreModules/RCTPerfMonitor.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,11 @@ - (void)show

[self updateStats];

[RCTKeyWindow() addSubview:self.container];
// This change is causing the performance monitor and element inspector to be added to the dev menus UIWindow
// instead of the main app
// [RCTKeyWindow() addSubview:self.container];
UIWindow *window = RCTSharedApplication().delegate.window;
[window addSubview:self.container];

_uiDisplayLink = [CADisplayLink displayLinkWithTarget:self selector:@selector(threadUpdate:)];
[_uiDisplayLink addToRunLoop:[NSRunLoop mainRunLoop] forMode:NSRunLoopCommonModes];
Expand Down
Loading