perf: eliminate conditional check in json strict mode hot path #651
+49
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor JSON parser creation to return specialized parser functions based on strict mode setting, removing the per-request `if (strict)` conditional check in the parsing hot path.
Phillip9587
requested review from
UlisesGascon,
bjohansebas,
Copilot,
jonchurch and
wesleytodd
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the JSON parser logic by extracting the parse function into a separate helper function createJsonParser. The refactoring improves code organization by separating parser creation from middleware setup, and fixes an incorrect JSDoc return type annotation.
Key Changes
- Extracted inline
parsefunction into a newcreateJsonParserhelper function that returns the appropriate parser based on thestrictoption - Corrected JSDoc return type annotation for
firstcharfunction from{function}to{string | undefined}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the JSON parser to eliminate the per-request
if (strict)conditional check from the parsing hot path.Instead of checking strict mode during parsing, we now create specialized parser functions at middleware initialization based on the strict option.
I'm aware that this introduces some code duplication between the strict and non-strict parser implementations, but I think that is a necessary trade-off.