express triage

[gireeshpunathil]

team -

I plan to spend some time helping with express triage, along with my colleague, @HarshithaKP

I had a meeting with @wesleytodd in August, and here is what that roughly came out:

We define a triage process and document it. The triage process is as follows:

1. tag all the open issues as: needs triage, bug or enhancement, based on the qualifying criteria that we apply after the due analysis on the issue
2. Document the process under https://github.com/expressjs/express/blob/master/Contributing.md for wider awareness so that no one (in the package maintenance team) is caught by surprise.

Please let me know what do you think!

• the scope for this initiative is all the repos under express umbrella
• we also entreat more people to join the triage team to reduce the backlog and improve our responsiveness to end-user issues
• we have started looking at multer as a starting point (based on backlog count), and touched some issues. Would be good if some of the owners or maintainers to have a look at those and share their candid opinions - we are not SMEs and not fully skilled in the technology (but definitely striving to ramp up!) so this feedback is important to make course corrections as we go!

Thanks in advance!

[wesleytodd]

Sorry I have been very busy since then, but I want this to move forward. I was hoping some of the other team members would have shared their opinions. If this does not get any objections soon I will start by adding you (@gireeshpunathil) to the triage role on this org. This should at least get "triagers" to be able to tag and close issues.

See here for more info on the new roles: https://help.github.com/en/articles/repository-permission-levels-for-an-organization

[dougwilson]

I'm so glad that github has improved the roles for members. I am onboard. There is a PR in express with the draft of the triage stuff, which I presume is related to this and I'll merge that into master shortly.

[helio-frota]

hi,
I'm interested in contribute with this effort by following the guidelines presented on the first comment, as well looking into multer as start point.

So, not a full time thing and not fully skilled in the technology, but yeah striving to ramp up.

[LinusU]

@helio-frota I would love to get some help with triaging in Multer. There are sooo many issues that are simply people asking how to do specific tings not really related to Multer, or that pastes some code and asks me to debug it.

I had a long vacation and my inbox still haven't recovered so I haven't been able to get to all projects, still have ~400 notifications left to go thru 😅

[helio-frota]

@LinusU yup, not a problem. 👍

But like @wesleytodd wrote on comment above:

This should at least get "triagers" to be able to tag and close issues.

After an overall look on issues and PRs, that is definitely one action to be done because we need to "cleanup the house" first to have a better focal point.

@wesleytodd When you have a time, can you please add me as "triagers" ?

@gireeshpunathil What do you think the triagers "/cc @" each other for each issue and PR so we can increase the % of response with a LGTM or a different point of view. Please let'me know.

@gireeshpunathil Here an example: expressjs/multer#798 (comment)
I exposed my opinion, and if you add a LGTM we close the PR.
The same applies for the others "triagers"

Please let me know if that approach makes sense

[gireeshpunathil]

@helio-frota - thanks.

• if triagers constitute a team together, @ mentioning is a good idea. Until such times, plain cc individuals makes sense.
• however, for closing non-trivial issues (where the OP have some convictions about the their point of view, there are differing views between involved parties etc.) I suggest we bring in the lead maintainer into the view to take a call?
• for trivial issues - yes, a mutual consensus or even direct closure (in case of inactive issues) make more sense
• I would prioritize issues over PRs.
• In my first scan of multer, I remember finding a good number of PR candidates emanating from issues I expect the similar pattern from other projects as well. When we interlock, we can discuss what, and how to treat insights coming out of triage work, for the long term benefit of the subject project.

[helio-frota]

I agree and going to get aligned with these points.

[wesleytodd]

👍 to everything @gireeshpunathil said, especially having non-trivial issues spot checked by one of the primary maintainers of the repo.

Also, to test it out @gireeshpunathil I gave you the triage role in this repo, can you make sure that you see all the appropriate buttons (tag, close, etc)?

@wesleytodd When you have a time, can you please add me as "triagers" ?

I need @dougwilson to add me (and probably the whole group of active TC members) as admin on the other orgs.

Also, for everyone here, can you start by reading and collaborating on the document started by @gireeshpunathil here: expressjs/express#4055

[gireeshpunathil]

thanks @wesleytodd - as you can see, I now have the triage role.