docs: clarify release authorization and permissions in release process #387
Conversation
Signed-off-by: Sebastian Beltran <[email protected]>
|
cc: @expressjs/express-tc |
Signed-off-by: Sebastian Beltran <[email protected]>
|
General feedback here is that it changes enough things that it is difficult to determine what the specific change requested here was. Im pro clarifying, but don't want this PR to add/change requirements for release, but better cpature our current reality. So possibly decomposing this PR into changes we can look at one at a time. Edit: just to capture other stuff we talked about, we should also ensure that we tell folks to target the last major when doing a new major GH relase. Bc we have missed in the past breaking changes that were landed in a beta, but were left out of the X.0.0 release notes! Also, we could create a specific doc for release, as this is focused mostly on Express and does not generalize to other package |
docs/contributing/release-process.md
Outdated
|
|
||
| Release authorization is given by the Express TC. Once authorized, an individual | ||
| must have the following access permissions: | ||
| According to project governance, only package Captains or members of the Technical Committee (TC) are permitted to make releases. Captains have the freedom to make releases for their own package whenever necessary, while TC members may make releases for any package as needed. |
There was a problem hiding this comment.
Yeah, this feels like just missed wording when we adopted the Captain's approach. So +1 on this line as individual pr's as per @jonchurch's comment.
…tion" This reverts commit 891cdf7.
Signed-off-by: Sebastian Beltran <[email protected]>
| release commit and push changes to the expressjs/express repository | ||
| (see Steps 4 and 5). | ||
| The person making the release must be either the package captain or a member of the TC in | ||
| order to have sufficient permissions to do the work. |
There was a problem hiding this comment.
This change is because it was referring only to Express and not in general
Signed-off-by: Sebastian Beltran <[email protected]>
6 participants
If two captains are not part of the TC, and the other captain gives authorization to release the package, is that valid? Or does there always have to be authorization from the TC?