Skip to content

Conversation

hiroppy
Copy link
Contributor

@hiroppy hiroppy commented Feb 13, 2018

.eslintrc is deprecated.
See https://eslint.org/docs/user-guide/configuring#configuration-file-formats.

I changed to .eslintrc.yaml because Node is using Yaml.(nodejs/node#7699)

@dougwilson
Copy link
Contributor

Nice, didn't even know this! Is it possible to name it .eslintrc.yml to match .travis.yml?

@dougwilson dougwilson added the pr label Feb 13, 2018
.eslintrc.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a space before the ending } but the space isn't balanced on the other side.

@hiroppy hiroppy force-pushed the feature/rename-eslintrc branch 2 times, most recently from 960bc43 to 8afd9e8 Compare February 13, 2018 19:33
@hiroppy
Copy link
Contributor Author

hiroppy commented Feb 13, 2018

@dougwilson PTAL;)

@hiroppy hiroppy changed the title lint: rename .eslintrc to .eslintrc.yaml lint: rename .eslintrc to .eslintrc.yml Feb 13, 2018
@hiroppy hiroppy force-pushed the feature/rename-eslintrc branch from 8afd9e8 to 1e0ffa0 Compare February 13, 2018 19:47
@dougwilson dougwilson self-assigned this Feb 13, 2018
@hiroppy hiroppy deleted the feature/rename-eslintrc branch February 14, 2018 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants