-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
docs: request for triager role for maxakuru #4122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Makes sense @dougwilson. Sorry I thought we had approved @gireeshpunathil's example. What commit message would you like for this? |
|
We did approve it, but the comment message that was landed was different from the normal pattern. Notably it had a reference to the PR in parenthesis on the first line and then in the body had a bullet point duplicating the message for some reason. |
|
Yep, my fault. I squashed because of the fixup and didn't edit the message it generated. We will make sure the follow up ones follow the pattern. Sorry! |
|
It's no problem, anything can be fixed in git. The only down site is that the merge reference in the original PR will then be broken (and all other merged commits made after it but before the message gets fixed would also have broken refs in the GitHub UI). We should get #4055 merged to add the triage defintion and stuff to the doc and then land these on top of that, I think. Let me know your thoughts on that plan. |
|
Ok, yeah lets merge that to |
|
Ok. Just remember the down side will be when it goes back to master all the commit hashes will change, which will break the references to the merged commits in the GitHub UI if that matters at all (I don't care too much, but not sure if others cared about the links working). |
|
Ok, glad you were around @dougwilson to catch this! It was too hectic in there to realistically manage merging these well. To follow up: @maxakuru is added to the triage role, but lets wait until we have a clear merge plan (hopefully tomorrow I can carve out time to review the new changes to the doc) to merge this. I will comment in the other PR's for the status and a follow up so everyone knows what is going on. cc: @expressjs/triagers |
|
No problem! I just got home and plan to get it sorted out tonight as my only priority for OS work today :) It got quite busy at work so I dropped off earlier, haha. |
|
Role added and merged in 7f5573e |
I have read and understood the project's Contributing guide.
I also have read and understood the process and best practices around Express triaging.
I request for a triager role for the below orgs:
jshttp
pillarjs
express
Refs: #4055