Skip to content

Conversation

@Phillip9587
Copy link
Member

The Buffer object is globally available in Node.js, so there is no need to explicitly require it.

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the history.md file? Sorry for being pedantic, but until we automate it I want to make sure we dont miss something in the release notes on accident.

@Phillip9587
Copy link
Member Author

Phillip9587 commented Nov 15, 2024

@wesleytodd Does this require an entry in HISTORY.md? The changes don't alter any behavior; they simply remove unnecessary requires of the global buffer.

Edit: I just read your comment on #6147 and #6176 and just added the entry

The Buffer object is globally available in Node.js, so there is no need to explicitly require it.
@Phillip9587 Phillip9587 force-pushed the remove-buffer-require branch from 842601c to d246446 Compare November 15, 2024 16:08
@wesleytodd
Copy link
Member

Thanks! yeah we will be automating that, but I think there is some question still of how deep we want to go on the automation, so it has not happened yet. Just making sure we don't make a mistake by abandoning the process even if it is a bad process 😄 .

@wesleytodd wesleytodd merged commit 9f8589e into expressjs:master Nov 15, 2024
21 checks passed
@bjohansebas bjohansebas mentioned this pull request Mar 15, 2025
@UlisesGascon UlisesGascon mentioned this pull request Mar 23, 2025
68 tasks
@wesleytodd wesleytodd mentioned this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants