feat: remove unused functions (#1590) #1698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
chrisdel101
reviewed
Nov 27, 2024
Closed
chrisdel101
approved these changes
Nov 28, 2024
Contributor
chrisdel101
left a comment
chrisdel101
left a comment
There was a problem hiding this comment.
Okie if you're doing these later than I guess overall I'd just like a one line comment on all non-super obvious JS funcs in the next iteration.
Otherwise I don't see these changes break anything.
Member
Author
|
I need approval with write permissions cc @expressjs/express-tc |
wesleytodd
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second PR, which is part of #1590, removes unused functionalities from the page.