Skip to content

Abort file upload on request 'close' event #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Abort file upload on request 'close' event #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c15360
Close WriteStream on request close
adskjohn Dec 13, 2016
c434854
abortWithCode when request is closed
adskjohn Dec 13, 2016
0ca2e87
Standard lint changes
adskjohn Dec 13, 2016
8c2cf62
Standard lint changes
adskjohn Dec 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/make-middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ function makeMiddleware (setup) {
abortWithCode('LIMIT_FILE_SIZE', fieldname)
})

var closed = false
req.on('close', function () {
closed = true
})

storage._handleFile(req, file, function (err, info) {
if (aborting) {
appender.removePlaceholder(placeholder)
Expand All @@ -157,6 +162,9 @@ function makeMiddleware (setup) {
appender.replacePlaceholder(placeholder, fileInfo)
uploadedFiles.push(fileInfo)
pendingWrites.decrement()
if (closed) {
return abortWithCode('REQUEST_CLOSED')
}
indicateDone()
})
})
Expand Down
3 changes: 3 additions & 0 deletions storage/disk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ DiskStorage.prototype._handleFile = function _handleFile (req, file, cb) {
size: outStream.bytesWritten
})
})
req.on('close', function () {
outStream.end()
})
})
})
}
Expand Down