Upgrade to kubernetes.model.version 1.0.66 #646
Conversation
|
This PR includes the upgrade of kubernetes-model to using openshift and kubernetes 1.5.x |
|
@iocanel @jimmidyson I've rebased this PR, would you be able to review when you get 2 mins and we can release it, I'll then take care of fabric8, fabric8-maven-plugin and downstream projects. Thanks |
| import io.fabric8.kubernetes.api.model.extensions.IngressList; | ||
| import io.fabric8.kubernetes.api.model.extensions.Job; | ||
| import io.fabric8.kubernetes.api.model.extensions.JobList; | ||
| import io.fabric8.kubernetes.api.model.Job; |
There was a problem hiding this comment.
These packages shouldn't have changed. Let me take a look at the model again - will do that now.
There was a problem hiding this comment.
Hmm this is really a breaking change in kube model that would affect anyone using the existing Job stuff, but this is caused by the change in go package to batch from apps. Thoughts on what to do here? I'm kind of thinking this is OK now but we should at least bump model version to 1.1 with this change (strictly speaking it should be 2 as breaking change).
There was a problem hiding this comment.
how about we go for version 2?
There was a problem hiding this comment.
version 2 sounds good to me
There was a problem hiding this comment.
Done - can you bump version to 2.0-SNAPSHOT then please
|
@iocanel Any concerns with this before I merge? |
|
@jimmidyson: No concerns from my side. |
… from extensions to batch
|
Thanks @rawlingsj - [merge] |
5 participants
No description provided.