Skip to content

Conversation

@aswinayyolath
Copy link
Contributor

@aswinayyolath aswinayyolath commented Nov 18, 2024

Remove depricated getVersion() method from CRDInfo

Fixes #6609

I tested changes by building the project

Screenshot 2024-11-18 at 2 18 11 PM

Also ran test for crd-generator

Screenshot 2024-11-18 at 2 18 22 PM

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Remove depricated getVersion() method from CRDInfo

Contributes to: fabric8io#6609

Signed-off-by: Aswin A <[email protected]>
@aswinayyolath
Copy link
Contributor Author

@manusa / @rohanKanojia can you take a look

@sonarqubecloud
Copy link

@manusa manusa added this to the 7.0.0 milestone Nov 18, 2024 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 6fbc70f into fabric8io:main Nov 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated CRDInfo.getVersion method

3 participants