Skip to content

Conversation

@dkaukov
Copy link
Contributor

@dkaukov dkaukov commented Dec 16, 2024

Description

Change rolling restart/pause/resume to use rfc6902 JSON patch.

Fixes #6658
Fixes #2516

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
Copy link
Member

manusa commented Dec 24, 2024

Thanks for looking into this.
I need to do a more thorough review to verify that nothing breaks (especially in older clusters).
If everything is fine this will be shipped in 7.1.

@manusa manusa force-pushed the rolling_patch_rfc6902 branch from d51786e to 65a3ab0 Compare January 16, 2025 10:34
@manusa manusa added this to the 7.1.0 milestone Jan 16, 2025 — with automated-tasks
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 40a7763 into fabric8io:main Jan 16, 2025
20 of 21 checks passed
@dkaukov dkaukov deleted the rolling_patch_rfc6902 branch January 21, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mock server support for rolling restart Cannot use deployment rolling restart API with CRUD mockwebserver

3 participants