Enable watch implicitly unless on CI #533
Merged
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gaearon
force-pushed
the
implicit-watch
branch
from
f0101f1 to
01e5714
Compare
Merged
stayradiated
pushed a commit
to stayradiated/create-react-app
that referenced
this pull request
Sep 7, 2016
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #532.
By default project won’t have
--watch.We will always assume that
react-scripts testlaunches the watcher.However we offer an escape hatch. If
process.env.CIis defined, we disable watching. This should satisfy most use cases, and people who really insist on not using a watcher can alwaysCI=true npm test. However our intention is to keep improving the watcher and we will push for it to become the default workflow.