refactor: extract has and warning #261

noscripter · 2019-02-27T07:27:10Z

According to DRY, extract has and warning message to lib as well as making the failing tests pass.

checkPropTypes.js

factoryWithTypeCheckers.js

checkPropTypes.js

__tests__/PropTypesDevelopmentStandalone-test.js

ljharb

The PR might need to be rebased.

__tests__/PropTypesDevelopmentStandalone-test.js

[Refactor] extract has

e32c490

facebook-github-bot added the CLA Signed label Feb 27, 2019

ljharb suggested changes Feb 28, 2019

View reviewed changes

ljharb reviewed Feb 28, 2019

View reviewed changes

__tests__/PropTypesDevelopmentStandalone-test.js Outdated Show resolved Hide resolved

ljharb force-pushed the extract_has branch from 5d5d2e3 to e32c490 Compare March 3, 2019 07:21

ljharb approved these changes Mar 3, 2019

View reviewed changes

ljharb merged commit e32c490 into facebook:master Mar 3, 2019

snyk-bot mentioned this pull request Mar 3, 2023

[Snyk] Upgrade prop-types from 15.6.1 to 15.8.1 OutSystems/react-select#33

Open

BuloZB mentioned this pull request May 20, 2024

[Snyk] Upgrade prop-types from 15.6.0 to 15.8.1 BuloZB/speech-to-text-nodejs#5

Open

MarwanShehata mentioned this pull request May 24, 2024

[Snyk] Upgrade prop-types from 15.6.2 to 15.8.1 MarwanShehata/ReactND-MyReads-App#31

Open

This was referenced May 24, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 ManuelDevWeb/ProjectMoviesServerSideRender#1103

Open

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 ManuelDevWeb/platziVideoReact#313

Open

nejidevelops mentioned this pull request May 24, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 nejidevelops/alx-react#53

Open

mjperrins mentioned this pull request May 25, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 ibm-self-serve-assets/ibm-enterprise-runbooks#214

Open

jeremyjohns10 mentioned this pull request May 28, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 wevote/WebApp#3927

Closed

Artur-data-DEV mentioned this pull request Jun 4, 2024

[Snyk] Upgrade prop-types from 15.6.2 to 15.8.1 Artur-data-DEV/blog-adonis-reactjs-react-native-airbnb-web#4

Open

This was referenced Jun 18, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 keiserjb/blogs-d8-gatsby#4

Open

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 keiserjb/gatsby_training#6

Open

apiiro-snyk mentioned this pull request Jul 3, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 apiiro-snyk/mitmproxy#4

Open

mjperrins mentioned this pull request Jul 17, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 ibm-self-serve-assets/ibm-gsi-cloudnative-journey#296

Open

This was referenced Jul 19, 2024

[Snyk-dev] Upgrade prop-types from 15.7.2 to 15.8.1 aztek/liferay-portal#10

Open

[Snyk-dev] Upgrade prop-types from 15.7.2 to 15.8.1 aztek/liferay-portal#11

Open

mjperrins mentioned this pull request Jul 23, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 ibm-self-serve-assets/ibm-gsi-cloudnative-journey#301

Open

A2booky mentioned this pull request Aug 6, 2024

[Snyk] Upgrade prop-types from 15.5.8 to 15.8.1 scrambledeggs/recyclerlistview#1

Open

This was referenced Aug 9, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 Stanislav1975/redux#6

Open

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 Stanislav1975/redux#11

Open

udilbar mentioned this pull request Sep 6, 2024

[Snyk] Upgrade: , , prop-types, clsx, , , , formik, history, react-feather, react-router, react-router-dom, react-scripts, yup udilbar/react-authentication-with-context-api#149

Open

This was referenced Sep 6, 2024

[Snyk] Upgrade: , , , css-loader, prop-types nejidevelops/alx-react#205

Open

[Snyk] Upgrade: , , , css-loader, prop-types nejidevelops/alx-react#206

Open

[Snyk] Upgrade: , , , css-loader, prop-types nejidevelops/alx-react#210

Open

udilbar mentioned this pull request Sep 18, 2024

[Snyk] Upgrade: , , prop-types, clsx, , , , formik, history, react-feather, react-router, react-router-dom, react-scripts, yup udilbar/react-authentication-with-context-api#156

Open

Karol-Sobolewski mentioned this pull request Sep 18, 2024

[Snyk] Upgrade: react, react-dom, http-server, prop-types, react-redux, redux, react-beautiful-dnd, react-router-dom, shortid Karol-Sobolewski/to-do-list#351

Open

MarwanShehata mentioned this pull request Sep 18, 2024

[Snyk] Upgrade: react, react-dom, prop-types, react-router-dom, react-scripts MarwanShehata/ReactND-MyReads-App#39

Open

mjperrins mentioned this pull request Sep 19, 2024

[Snyk] Upgrade: gatsby-plugin-sharp, prop-types, gatsby-plugin-mdx, gatsby-theme-carbon, prismjs ibm-self-serve-assets/ibm-gsi-cloudnative-journey#324

Open

Security-Test-Account mentioned this pull request Sep 19, 2024

[Snyk] Upgrade: react, react-dom, , antd, prop-types, react-redux, react-router-dom, redux, redux-saga Security-Test-Account/crAPI#109

Open

MarwanShehata mentioned this pull request Sep 19, 2024

[Snyk] Upgrade: react, react-dom, prop-types, react-router-dom, react-scripts MarwanShehata/ReactND-MyReads-App#40

Open

mjperrins mentioned this pull request Sep 20, 2024

[Snyk] Upgrade: gatsby-plugin-sharp, prop-types, gatsby-plugin-mdx, gatsby-theme-carbon, prismjs ibm-self-serve-assets/ibm-gsi-cloudnative-journey#325

Open

udilbar mentioned this pull request Sep 20, 2024

[Snyk] Upgrade: , , prop-types, clsx, , , , formik, history, react-feather, react-router, react-router-dom, react-scripts, yup udilbar/react-authentication-with-context-api#157

Open

MarwanShehata mentioned this pull request Sep 20, 2024

[Snyk] Upgrade: react, react-dom, prop-types, react-router-dom, react-scripts MarwanShehata/ReactND-MyReads-App#41

Open

mjperrins mentioned this pull request Sep 21, 2024

[Snyk] Upgrade: gatsby-plugin-sharp, prop-types, gatsby-plugin-mdx, gatsby-theme-carbon, prismjs ibm-self-serve-assets/ibm-gsi-cloudnative-journey#326

Open

Security-Test-Account mentioned this pull request Sep 21, 2024

[Snyk] Upgrade: react, react-dom, , antd, prop-types, react-redux, react-router-dom, redux, redux-saga Security-Test-Account/crAPI#110

Open

udilbar mentioned this pull request Sep 21, 2024

[Snyk] Upgrade: , , prop-types, clsx, , , , formik, history, react-feather, react-router, react-router-dom, react-scripts, yup udilbar/react-authentication-with-context-api#158

Open

MarwanShehata mentioned this pull request Sep 21, 2024

[Snyk] Upgrade: react, react-dom, prop-types, react-router-dom, react-scripts MarwanShehata/ReactND-MyReads-App#42

Open

Karol-Sobolewski mentioned this pull request Sep 21, 2024

[Snyk] Upgrade: react, react-dom, http-server, prop-types, react-redux, redux, react-beautiful-dnd, react-router-dom, shortid Karol-Sobolewski/to-do-list#352

Open

nejidevelops mentioned this pull request Sep 21, 2024

[Snyk] Upgrade: , , , css-loader, prop-types nejidevelops/alx-react#229

Open

MarwanShehata mentioned this pull request Sep 23, 2024

[Snyk] Upgrade: react, react-dom, prop-types, react-router-dom, react-scripts MarwanShehata/ReactND-MyReads-App#43

Open

kundanthe mentioned this pull request Sep 24, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 kundanthe/opentok-react-native#3

Open

brandonyee333 mentioned this pull request Oct 3, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 brandonyee333/test#3

Open

CASABECI mentioned this pull request Oct 5, 2024

[Snyk] Upgrade prop-types from 15.6.0 to 15.8.1 CASABECI/stellarexplorer#5

Open

dab9171355 mentioned this pull request Oct 27, 2024

[Snyk] Upgrade prop-types from 15.5.10 to 15.8.1 DeloitteAU/react-habitat#56

Open

topolik mentioned this pull request Oct 30, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 topolik/liferay-portal#863

Open

mjperrins mentioned this pull request Nov 2, 2024

[Snyk] Upgrade prop-types from 15.7.2 to 15.8.1 ibm-self-serve-assets/ibm-gsi-cloudnative-journey#335

Open

sebastianthulin mentioned this pull request Nov 8, 2024

[Snyk] Upgrade prop-types from 15.6.2 to 15.8.1 helsingborg-stad/modularity-login-form#4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor: extract has and warning #261

refactor: extract has and warning #261

Uh oh!

noscripter commented Feb 27, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ljharb left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

refactor: extract has and warning #261

refactor: extract has and warning #261

Uh oh!

Conversation

noscripter commented Feb 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

noscripter commented Feb 27, 2019 •

edited

Loading