Update scrollview.md #3869
Merged
Update scrollview.md #3869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pagingEnabled` **is** supported on Android. I tested it and it just seems to work.
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Simek
reviewed
Oct 4, 2023
There was a problem hiding this comment.
Hey @adriancuadrado, thank you for spotting that! 👍
It looks like this comment has been added a while ago in facebook/react-native#14844 but it is still present in the source code:
Can you prepare the PR removing it from source, ideally with test/demo in RNTester? Alternatively it would be nice to find PR/commit adding the support. With the fact confirmed, and changes in, we can follow up on this docs PR.
adriancuadrado
added a commit
to adriancuadrado/react-native
that referenced
this pull request
Oct 4, 2023
`pagingEnabled` **is** supported on Android. I tested it and it just seems to work. See facebook/react-native-website#3869 (review)
adriancuadrado
added a commit
to adriancuadrado/react-native
that referenced
this pull request
Oct 4, 2023
`pagingEnabled` **is** supported on Android. I tested it and it just seems to work. See facebook/react-native-website#3869 (review)
adriancuadrado
added a commit
to adriancuadrado/react-native
that referenced
this pull request
Oct 4, 2023
`pagingEnabled` **is** supported on Android. I tested it and it just seems to work. See facebook/react-native-website#3869 (review)
This is the PR: facebook/react-native#39801 I can't add a test/demo in RNTester because I am getting some errors when I follow these instructions. Mind doing it yourself? |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 4, 2023
Summary: `pagingEnabled` **is** supported on Android. I tested it and it just seems to work. See facebook/react-native-website#3869 (review) I just edited a comment to remove a statement that is plain wrong. ## Changelog: [Internal] Update comment Pull Request resolved: #39801 Reviewed By: fabriziocucci Differential Revision: D49910049 Pulled By: javache fbshipit-source-id: c17f6794ea920d282b924dc47ee55fd5c349efb5
NickGerleman
approved these changes
Dec 3, 2023
sunnylqm
added a commit
to reactnativecn/react-native-website
that referenced
this pull request
Dec 10, 2023
commit 6a28b05 Author: Kartik Shankhavaram <[email protected]> Date: Sat Dec 9 22:50:21 2023 +0800 Change 'use' to 'lose' to signify that functions are still accessible (facebook#3949) commit 822b280 Author: Alex Hunt <[email protected]> Date: Fri Dec 8 13:00:46 2023 +0000 [docs] Fix name for 0.73 versioned docs (facebook#3948) commit 4818763 Author: Nick Gerleman <[email protected]> Date: Thu Dec 7 10:56:32 2023 -0800 Lint and typecheck examples against RN 0.73 (facebook#3946) * Lint and typecheck examples against RN 0.73 Updates the harness for linting snack examples to the newest version of RN. * Update Netlify Node version commit cc46589 Author: Nick Gerleman <[email protected]> Date: Thu Dec 7 10:56:04 2023 -0800 Add `alignContent: 'space-evenly'` (facebook#3888) * Add `alignContent: 'space-evenly'` Coming with 0.74 facebook/react-native#41020 * Update layout-props.md commit 9f7093c Author: Christoph Purrer <[email protected]> Date: Thu Dec 7 14:06:00 2023 +0100 Simplify C++ TM struct generation (facebook#3947) Update documentation to match: facebook/react-native#41645 commit 59278e7 Author: Nick Gerleman <[email protected]> Date: Thu Dec 7 01:28:12 2023 -0800 Add `--frozen-lockfile` to `yarn install` (facebook#3945) To catch cases where dependency changes require a lockfile change that wasn't comited alongside. commit 06ba8ea Author: Nick Gerleman <[email protected]> Date: Thu Dec 7 00:59:10 2023 -0800 Revert "fixed peer dependency issues (facebook#3942)" (facebook#3944) This reverts commit 1bcb60f. commit 1bcb60f Author: Shantanu Gupta <[email protected]> Date: Thu Dec 7 08:52:32 2023 +0000 fixed peer dependency issues (facebook#3942) * fixed peer dependency issues * removed lingering file commit 79ff42a Author: Zeya Peng <[email protected]> Date: Wed Dec 6 14:20:06 2023 -0500 Update native-components-android.md (facebook#3941) commit f0c4b80 Author: Aike van den Brink <[email protected]> Date: Wed Dec 6 19:46:03 2023 +0100 Update new-architecture-app-intro.md (facebook#3938) Fixed small spelling mistake commit f89ab82 Author: Alex Hunt <[email protected]> Date: Wed Dec 6 17:56:40 2023 +0000 [docs] Cut version 0.73.0 (facebook#3940) commit 83e816b Author: Alex Hunt <[email protected]> Date: Wed Dec 6 17:15:14 2023 +0000 [blog] Add 0.73 announcement post (facebook#3931) commit d8c78ad Author: Thibault Malbranche <[email protected]> Date: Wed Dec 6 17:33:48 2023 +0100 fix(Image): update link to correct file (facebook#3939) commit 821172e Author: Sarvar Rose <[email protected]> Date: Mon Dec 4 16:20:11 2023 +0530 correct type of Pressable `style` prop (facebook#3936) commit b1379a7 Author: adriancuadrado <[email protected]> Date: Mon Dec 4 00:57:19 2023 +0100 Update scrollview.md (facebook#3869) `pagingEnabled` **is** supported on Android. I tested it and it just seems to work. commit 11258b1 Author: Alan <[email protected]> Date: Mon Dec 4 07:55:12 2023 +0800 fix: remove useless points (facebook#3934) commit 8400279 Author: Christoph Purrer <[email protected]> Date: Sun Dec 3 09:57:25 2023 +0100 Revert "Simplify C++ TM struct generation (facebook#3930)" (facebook#3935) This reverts commit 7396470. commit 7396470 Author: Christoph Purrer <[email protected]> Date: Mon Nov 27 13:00:23 2023 +0100 Simplify C++ TM struct generation (facebook#3930) Update documentation to match: facebook/react-native#41645 commit 5616873 Author: Bailey Lissington <[email protected]> Date: Mon Nov 27 22:33:50 2023 +1300 Fixed grammatical error (facebook#3929)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pagingEnabledis supported on Android. I tested it and it just seems to work.