[Packager] can't resolve sha.js dependency (or any other with "." in name)

[mvayngrib]

sha.js, bn.js, dns.js all result in errors like:

Requiring module "testdot/index.ios" with unresolved dependencies: testdot/index.ios is waiting for sha.js/index
sha.js/index is not defined

[christopherdro]

@mvayngrib did you ever get this resolved?

[mvayngrib]

yea, sadly I didn't have time to dig in too deep so i hacked https://github.com/facebook/react-native/blob/master/packager/react-packager/src/DependencyResolver/haste/DependencyGraph/index.js#L121

from

var id = sansExtJs(name);

to

var id = name;

and everything worked

[christopherdro]

@mvayngrib How were you originally defining the requirements? Would you be able to provide an example project where this error occurs. That would help out a lot.

[mvayngrib]

here's a sample project: https://github.com/mvayngrib/breakdotdep

all i did was:

react-native init breakdotdep
cd breakdotdep
npm install --save hash.js
open breakdotdep.xcodeproj

in index.ios.js add

var hashjs = require('hash.js')

then hit Run and open Chrome Dev Tools and see:

index.ios.bundle:931 Error: 
 stack: Error: Requiring module "breakdotdep/index.ios" with unresolved dependencies: breakdotdep/index.ios is waiting for hash.js/lib/hash
hash.js/lib/hash is not defined
    at Error (native)
    at new ModuleError (http://localhost:8081/index.ios.bundle:107:18)
    at require (http://localhost:8081/index.ios.bundle:214:13)
    at Object.ErrorUtils.applyWithGuard (http://localhost:8081/index.ios.bundle:885:20)
    at require (http://localhost:8081/index.ios.bundle:196:25)
    at http://localhost:8081/index.ios.bundle:41408:2
 line: undefined
 message: Requiring module "breakdotdep/index.ios" with unresolved dependencies: breakdotdep/index.ios is waiting for hash.js/lib/hash
hash.js/lib/hash is not defined ModuleError

[amasad]

Fixed this internally, should go out in the next sync. Sorry for the delay.

[mvayngrib]

awesome!

[venocl]

Hi, I have the same problem with ddp.js even after applying the fix

[amasad]

@venocl This for sure works in the latest version 0.7.0-rc.2 I just installed ddp.js and double checked.