[iOS][cocoapods] 'RCTAnimation/RCTValueAnimatedNode.h' file not found

[skv-headless]

Description

'RCTAnimation/RCTValueAnimatedNode.h' file not found.
in current master https://github.com/facebook/react-native/tree/c233191485ef733aa7a8d4ea5c758b9e6a06964c

1. related to 28 of march changes. @janicduplessis might help
2. podspec test are passed. @alloy do you have ideas how tests could be improved?
   Maybe we need to run xcbuild to test?

Reproduction Steps and Sample Code

https://github.com/skv-headless/AwesomeProject - demo project based on this page https://facebook.github.io/react-native/docs/integration-with-existing-apps.html#cocoapods

Solution

It works if change #import <RCTAnimation/RCTValueAnimatedNode.h> to #import "RCTValueAnimatedNode.h"

Additional Information

• Platform: [iOS]
• Development Operating System: [MacOS]

[alloy]

podspec test are passed. @alloy do you have ideas how tests could be improved?
Maybe we need to run xcbuild to test?

Nah, we should ideally build all the subspecs, I’ll take a look at how long those take.

[alloy]

@skv-headless Your example fails to build from a fresh clone with different issues than the one this ticket is about. Can you make sure it fails with the exact issue you mention from a fresh clone (so no pod install, no npm install) ?

[alloy]

While enabling full podspec testing I did encounter this failure, which is probably the one you’re referring to:

In file included from /Users/eloy/Code/React/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.m:10:
/Users/eloy/Code/React/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h:12:9: fatal error: 'RCTAnimation/RCTValueAnimatedNode.h' file not found
#import <RCTAnimation/RCTValueAnimatedNode.h>

[skv-headless]

Yep. This error. I've updated repo in case it still needed. Are you going to update test script?

[alloy]

Yeah I’ll do that, and then we’ll see how much time it takes to complete on CI.

[alloy]

Pushed #13217

[shrutic]

I still get this error even in 0.44.0 where the code in RCTNativeAnimatedModule.h is updated from It works if change #import <RCTAnimation/RCTValueAnimatedNode.h> to #import "RCTValueAnimatedNode.h"

as mentioned by the original Bug logger. So the solution did not work for me.. Any other recommended solutions?

[iggyfisk]

This is fixed as of 7b7d6bb @skv-headless

[nartawak]

@iggyfisk Is it possible to have a 0.44 fix with this commit ?

[egorkhmelev]

For those who still searching for a quick solution. I was able to launch iOS app with RCTAnimation subspec by including following string to my package.json:

"scripts": {
  "postinstall": "sed -i '' 's\/#import <RCTAnimation\\/RCTValueAnimatedNode.h>\/#import \"RCTValueAnimatedNode.h\"\/' ./node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h",
  ...rest scripts
}

React: 16.0.0-alpha.12
ReactNative: 0.45.0-rc.0

Didn't work for me with above PR which already accepted in 0.45.0-rc.0