-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Closed
Labels
☂️ UmbrellaTo label issues that serve as coordination point and drivers for tasks in the react-native repoTo label issues that serve as coordination point and drivers for tasks in the react-native repoGood first issueInterested in collaborating? Take a stab at fixing one of these issues.Interested in collaborating? Take a stab at fixing one of these issues.Help Wanted
Issues ideal for external contributors.Issues ideal for external contributors.
Description
Description
Hey all 👋
We're looking for some community support to help us prepare the codebase of React Native Android to be ready to migrate to Kotlin. In this first stage we are looking for help to migrate tests to Kotlin
How to migrate a test
If you wish to convert one of the tests you should:
- Verify that the test is not claimed yet.
- Comment here that you claim a test.
- Start working on adding Kotlin support for the test.
- Make sure your environment is set up correctly (see below)
- Use this PR as inspiration: Convert RootViewTest to Kotlin - #37227
- Make sure the test run correctly (see below).
- Your Kotlin code should be formatted with ktfmt (see below).
- Send the PR for review. Ping @cortinico and @mdvacca for a review.
Setting up your environment
Make sure your environment is set correctly, specifically you need to:
- Fork react-native
- Clone react-native locally
- Run
yarninside your local fork (installation instruction for yarn are here) - Make sure you have Java 11 installed and the Android SDK configured (you can follow our official guide here)
Running your tests
You can run your tests either by using the Android Studio/IntelliJ UI or by invoking the following command in your React Native fork:
./gradlew :packages:react-native:ReactAndroid:test
Code formatting
Please use KtFmt to format Kotlin tests.
You can use the web UI to reformat directly from the browser:
https://facebook.github.io/ktfmt/
List of tests to migrate
- common/logging/FakeLoggingDelegate.java assigned to @MohamedRejeb
- react/CompositeReactPackageTest.java assigned to @MohamedRejeb
- react/animated/NativeAnimatedInterpolationTest.java assigned to @fabioh8010
- react/animated/NativeAnimatedNodeTraversalTest.java - Assigned to @ankit-tailor
- react/bridge/FallbackJSBundleLoaderTest.java Assigned to @fabioh8010
- react/bridge/InstanceHandleHelper.java assigned to @arslandogar
- react/bridge/JavaOnlyArrayTest.java assigned to @rozkminiacz
- react/bridge/JavaScriptModuleRegistryTest.java assigned to @stanwolverine
- react/bridge/ReactTestHelper.java assigned to @abdennour-jebbar-nw
- react/bridge/BaseJavaModuleTest.java assigned to @abdennour-jebbar-nw
- react/bridge/interop/FakeRCTEventEmitter.java assigned to @dcangulo
- react/bridge/interop/InteropModuleRegistryTest.java assigned to @dcangulo
- react/devsupport/MultipartStreamReaderTest.java assigned to @brunohensel
- react/devsupport/StackTraceHelperTest.java assigned to @koko57
- react/fabric/events/TouchEventDispatchTest.java assigned to @MohamedRejeb
- react/fabric/interop/FakeEventDispatcher.java assigned to @tarunrajput
- react/fabric/interop/InteropEventEmitterTest.java assigned to @stanwolverine
- react/modules/blob/BlobModuleTest.java assigned to @mateusz1913
- react/modules/camera/ImageStoreManagerTest.java assigned to @megatunger
- react/modules/clipboard/ClipboardModuleTest.java assigned to @hurali97
- react/modules/deviceinfo/DeviceInfoModuleTest.java assigned to @okwasniewski
- react/modules/dialog/DialogModuleTest.java assigned to @fathonyfath
- react/modules/network/HeaderUtilTest.java assigned to @TheMissouri
- react/modules/network/ReactCookieJarContainerTest.java assigned to @pk-218
- react/modules/network/ProgressiveStringDecoderTest.java assigned to @RyanGst
- react/modules/share/ShareModuleTest.java assigned to @siddarthkay
- react/packagerconnection/JSPackagerClientTest.java assigned to @brunohensel
- react/uimanager/UIManagerModuleConstantsHelperTest.java assigned to @ryanlntn
- react/uimanager/layoutanimation/InterpolatorTypeTest.java assigned to @Janjs
- react/util/JSStackTraceTest.java assigned to @aymane-missouri-nw
Rexogamer, cortinico, ankit-tailor, okwasniewski, szymonrybczak and 25 morekyawthura-gg, szymonrybczak, fabioh8010, siddarthkay, migueldaipre and 9 moreMohamedRejeb, fabioh8010, migueldaipre, dzikoysk, reichhartd and 3 more
Metadata
Metadata
Assignees
Labels
☂️ UmbrellaTo label issues that serve as coordination point and drivers for tasks in the react-native repoTo label issues that serve as coordination point and drivers for tasks in the react-native repoGood first issueInterested in collaborating? Take a stab at fixing one of these issues.Interested in collaborating? Take a stab at fixing one of these issues.Help Wanted
Issues ideal for external contributors.Issues ideal for external contributors.