Ensure the main AndroidManifest.xml is used

[lnikkila]

Rationale from the commit message:

Some Android projects might opt to use multiple manifest files, e.g. for
choosing different permissions based on the build type. Android's build
process merges the manifests; secondary manifests can omit everything
present in the main manifest. We shouldn’t rely on those secondary
manifests for information since crucial information like the package
name might not be present.

The story is that I was using multiple manifests and trying to run react-native link to link some libraries, that specific command kept failing with:

rnpm-install ERR! ERRPACKAGEJSON No package found. Are you sure it's a React Native project?

Turns out it couldn’t find the package name from the manifest since it was looking into the debug build type’s manifest that didn’t have it.

Links for reference:

• Manifest merging rules
• Build types

Please let me know if you need more info or if anything needs to be changed. Thanks!

[ghost]

By analyzing the blame information on this pull request, we identified @grabbou to be a potential reviewer.

[ghost]

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email [email protected] with your details so we can update your status.

[ghost]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[lnikkila]

Looks like the E2E tests are failing since bdc4731 in master.

[facebook-github-bot]

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @grabbou as a potential reviewer. Could you take a look please or cc someone with more context?

[grabbou]

Thanks for the PR! That addition looks interesting though I think it's a bit too much specific to your app needs. I mean - there's nothing wrong with that, but we would like to keep a balance of what CLI can do vs what we can maintain and test really well.

To make your requested changes still working, how about making manifestPath configurable through the config, as the rest of the properties?

Just replace https://github.com/lnikkila/react-native/blob/4273b48c34d334c9449462bce9a54c40b2585857/local-cli/core/config/android/index.js#L24

const manifestPath = findManifest(sourceDir);

with

const manifestPath = userConfig.manifestPath
   ? path.join(sourceDir, userConfig.manifestPath)
   : findManifest(sourceDir)

and you should be able to specify a path to your valid Manifest (if you have more than one)

PS. Don't forget to do the same for dependencyConfig! Your tests are ok :)

[lacker]

Hey, thanks everyone for contributing here. It seems like this pull request has been abandoned so I am going to close it. If you would like to work on this more then please feel free to reopen it!