[TextInput] returnKeyType, enablesReturnKeyAutomatically, more keyboardTypes #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ide
changed the title
arasmussen
force-pushed
the
master
branch
5 times, most recently
from
9b61be2 to
41453a5
Compare
…ove semicolons to keep code style
Lint code - change double quotes to single in website/jsdocs
Corrected typo in README
Website improvements
|
👍 |
…ntry more keyboardTypes This diff completes adding support for the following UITextField properties: returnKeyType: what the return key on the keyboard says enablesReturnKeyAutomatically: the return key is disabled iff there is no text entered. This too could be implemented in React but it feels better in UIKit right now because it is handled synchronously. secureTextEntry: obscure passwords keyboardType: added all the keyboard types, they are useful in different scenarios There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here. Added examples to the UIExplorer.
|
Superseded by #265 (+ secureTextEntry support!) |
harrykiselev
pushed a commit
to harrykiselev/react-native
that referenced
this pull request
Aug 5, 2015
Update broken link.
acoates-ms
pushed a commit
to acoates-ms/react-native
that referenced
this pull request
Jul 15, 2019
* Using optimized V8 bins * Updating V8 nuget version in build.gradle * Adding mapping for Image in ViewManagerRegistry * Removing wrongly added entry from the ViewManagerRegistry map
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
This was referenced Nov 16, 2020
react-one
pushed a commit
to react-one/react-native
that referenced
this pull request
Sep 24, 2021
This was referenced Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff completes adding support for the following UITextField properties:
There were varying degrees of support for these properties so it looks like this diff continues some unfinished work. I also updated the keyboardType enum to use native constants instead of strings like the other properties here.
Added examples to the UIExplorer.