Skip to content

[Android] [Lists] Workaround a wrong fling direction for inverted ScrollViews on Android P #21117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Android] [Lists] Workaround a wrong fling direction for inverted ScrollViews on Android P #21117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,18 @@ public void getClippingRect(Rect outClippingRect) {

@Override
public void fling(int velocityY) {
// Workaround.
// On Android P if a ScrollView is inverted, we will get a wrong sign for
// velocityY (see https://issuetracker.google.com/issues/112385925).
// At the same time, mOnScrollDispatchHelper tracks the correct velocity direction.
//
// Hence, we can use the absolute value from whatever the OS gives
// us and use the sign of what mOnScrollDispatchHelper has tracked.
final int correctedVelocityY = (int)(Math.abs(velocityY) * Math.signum(mOnScrollDispatchHelper.getYFlingVelocity()));


if (mPagingEnabled) {
flingAndSnap(velocityY);
flingAndSnap(correctedVelocityY);
} else if (mScroller != null) {
// FB SCROLLVIEW CHANGE

Expand All @@ -326,7 +336,7 @@ public void fling(int velocityY) {
getScrollX(), // startX
getScrollY(), // startY
0, // velocityX
velocityY, // velocityY
correctedVelocityY, // velocityY
0, // minX
0, // maxX
0, // minY
Expand All @@ -339,9 +349,9 @@ public void fling(int velocityY) {

// END FB SCROLLVIEW CHANGE
} else {
super.fling(velocityY);
super.fling(correctedVelocityY);
}
handlePostTouchScrolling(0, velocityY);
handlePostTouchScrolling(0, correctedVelocityY);
}

private void enableFpsListener() {
Expand Down