Skip to content

Remove PropTypes from InspectorOverlay #21345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Remove PropTypes from InspectorOverlay #21345

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f338450
refactor(inspector): update props types
kdastan Sep 27, 2018
1ed393a
fix: update style prop type
kdastan Sep 27, 2018
302fe68
feat: created inspected type
kdastan Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions Libraries/Inspector/InspectorOverlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,33 +12,29 @@

const Dimensions = require('Dimensions');
const ElementBox = require('ElementBox');
const PropTypes = require('prop-types');
const React = require('React');
const StyleSheet = require('StyleSheet');
const UIManager = require('UIManager');
const View = require('View');

import type {ViewStyleProp} from 'StyleSheet';

type EventLike = {
nativeEvent: Object,
};

class InspectorOverlay extends React.Component<{
inspected?: {
frame?: Object,
style?: any,
},
inspectedViewTag?: number,
onTouchViewTag: (tag: number, frame: Object, pointerY: number) => void,
}> {
static propTypes = {
inspected: PropTypes.shape({
frame: PropTypes.object,
style: PropTypes.any,
}),
inspectedViewTag: PropTypes.number,
onTouchViewTag: PropTypes.func.isRequired,
};
type Inspected = $ReadOnly<{|
frame?: Object,
style?: ViewStyleProp,
|}>;

type Props = $ReadOnly<{|
inspected?: Inspected,
inspectedViewTag?: ?number,
onTouchViewTag: (tag: number, frame: Object, pointerY: number) => mixed,
|}>;

class InspectorOverlay extends React.Component<Props> {
findViewForTouchEvent = (e: EventLike) => {
const {locationX, locationY} = e.nativeEvent.touches[0];
UIManager.findSubviewIn(
Expand Down