Skip to content

Remove PropTypes from MaskedViewIOS.ios.js #21346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove PropTypes from MaskedViewIOS.ios.js #21346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a86567
Remove PropTypes from MaskedViewIOS
nissy-dev Sep 27, 2018
87ff72a
add pipeline & fix children type
nissy-dev Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions Libraries/Components/MaskedView/MaskedViewIOS.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
* @flow
*/

const DeprecatedViewPropTypes = require('DeprecatedViewPropTypes');
const PropTypes = require('prop-types');
const React = require('React');
const StyleSheet = require('StyleSheet');
const View = require('View');
Expand All @@ -20,16 +18,16 @@ import type {ViewProps} from 'ViewPropTypes';

const RCTMaskedView = requireNativeComponent('RCTMaskedView');

type Props = {
type Props = $ReadOnly<{|
...ViewProps,

children: any,
children: React.Node,
/**
* Should be a React element to be rendered and applied as the
* mask for the child element.
*/
maskElement: React.Element<any>,
};
|}>;

/**
* Renders the child view with a mask specified in the `maskElement` prop.
Expand Down Expand Up @@ -68,11 +66,6 @@ type Props = {
*
*/
class MaskedViewIOS extends React.Component<Props> {
static propTypes = {
...DeprecatedViewPropTypes,
maskElement: PropTypes.element.isRequired,
};

_hasWarnedInvalidRenderMask = false;

render() {
Expand Down