Skip to content

Fabric: make getDebugProps of YogaStylableProps as virtual method #25388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fabric: make getDebugProps of YogaStylableProps as virtual method #25388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e906f79
Fabric: make getDebugProps of YogaStylableProps as virtual method
zhongwuzw Jun 25, 2019
e448bb9
Another try to use virtual inherit
zhongwuzw Jun 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ReactCommon/fabric/components/view/yoga/YogaStylableProps.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class YogaStylableProps;

typedef std::shared_ptr<const YogaStylableProps> SharedYogaStylableProps;

class YogaStylableProps {
class YogaStylableProps : public virtual DebugStringConvertible {
public:
YogaStylableProps() = default;
YogaStylableProps(const YGStyle &yogaStyle);
Expand All @@ -38,7 +38,8 @@ class YogaStylableProps {
#pragma mark - DebugStringConvertible (Partial)

public:
SharedDebugStringConvertibleList getDebugProps() const;
virtual ~YogaStylableProps() = default;
SharedDebugStringConvertibleList getDebugProps() const override;

#endif
};
Expand Down