Skip to content

Conversation

@vjeux
Copy link
Contributor

@vjeux vjeux commented Sep 16, 2015

beeper node modules has a return statement outside of a function which doesn't parse. To fix it, we mock it. Also, setupEnvPolyfills is no longer being used.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 16, 2015
@vjeux
Copy link
Contributor Author

vjeux commented Sep 16, 2015

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/639555172851204/int_phab to review.

beeper node modules has a `return` statement outside of a function which doesn't parse. To fix it, we mock it. Also, setupEnvPolyfills is no longer being used.
@vjeux
Copy link
Contributor Author

vjeux commented Sep 16, 2015

setupEnvPolyfills.js does not exist internally, I'll remove it directly from github in another commit.

@vjeux
Copy link
Contributor Author

vjeux commented Sep 16, 2015

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/639555172851204/int_phab to review.

@vjeux vjeux closed this in 36a8358 Sep 16, 2015
bparadie pushed a commit to bparadie/react-native that referenced this pull request Sep 16, 2015
Summary: beeper node modules has a `return` statement outside of a function which doesn't parse. To fix it, we mock it. Also, setupEnvPolyfills is no longer being used.
Closes facebook#2770

Reviewed By: @​svcscm

Differential Revision: D2448882

Pulled By: @vjeux
@vjeux vjeux deleted the fix_tests branch September 16, 2015 22:01
MattFoley pushed a commit to skillz/react-native that referenced this pull request Nov 9, 2015
Summary: beeper node modules has a `return` statement outside of a function which doesn't parse. To fix it, we mock it. Also, setupEnvPolyfills is no longer being used.
Closes facebook#2770

Reviewed By: @​svcscm

Differential Revision: D2448882

Pulled By: @vjeux
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
Summary: beeper node modules has a `return` statement outside of a function which doesn't parse. To fix it, we mock it. Also, setupEnvPolyfills is no longer being used.
Closes facebook/react-native#2770

Reviewed By: @​svcscm

Differential Revision: D2448882

Pulled By: @vjeux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants