Support/use Promises #290
Support/use Promises #290
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
What problem are you trying to solve with promisifying this file? |
|
Not only this file. I would like to promisify tasks as extractDocs and generate, as would work better without depending on callbacks. What do you think? |
|
It's unclear to me what the benefits would be, all the extractDocs methods are synchronous so adding asynchronocity in the mix would only make the code harder to work with. As for the server itself, it's working fine as is. It's tempting to go around a codebase and use the latest shiny abstraction but you should only do that to solve problems. If there aren't problems, adding abstraction is a net negative operation |
|
Gotcha, you're right. Valid only commits to log repair :) |
3 participants
I think that would be a good promises apply. Even for more complex tasks. What do you think?
I started developing locally using bluebird to "promisify" all functions. For now, I just sent half PR, without promises part. If agree, I'll add promises feature.