Skip to content

Conversation

@janicduplessis
Copy link
Contributor

Summary

Use the same script as android to build the codegen package. This also fixes the issue in #30292.

Changelog

[Internal] - Use react-native-codegen build script in rn-tester

Test Plan

Tested that using the script works when using pod install

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Oct 31, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 7dcecb2

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,507,188 +0
android hermes armeabi-v7a 7,098,964 +0
android hermes x86 7,945,335 +0
android hermes x86_64 7,856,391 +0
android jsc arm64-v8a 8,971,903 +0
android jsc armeabi-v7a 8,546,801 +0
android jsc x86 8,971,534 +0
android jsc x86_64 9,522,859 +0

Base commit: 7dcecb2

@janicduplessis janicduplessis deleted the patch-9 branch November 13, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants