Skip to content

feat: add more context to invalid text string parents #32544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: add more context to invalid text string parents #32544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/Renderer/implementations/ReactFabric-dev.fb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5110,7 +5110,7 @@ function createTextInstance(
) {
{
if (!hostContext.isInAParentText) {
error("Text strings must be rendered within a <Text> component.");
error(`Text string "${text}" must be rendered within a <Text> component.`);
}
}

Expand Down
2 changes: 1 addition & 1 deletion Libraries/Renderer/implementations/ReactFabric-dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4947,7 +4947,7 @@ function createTextInstance(
internalInstanceHandle
) {
if (!hostContext.isInAParentText) {
throw Error("Text strings must be rendered within a <Text> component.");
throw Error(`Text string "${text}" must be rendered within a <Text> component.`);
}

var tag = nextReactTag;
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Renderer/implementations/ReactFabric-prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1900,7 +1900,7 @@ function createTextInstance(
internalInstanceHandle
) {
if (!hostContext.isInAParentText)
throw Error("Text strings must be rendered within a <Text> component.");
throw Error(`Text string "${text}" must be rendered within a <Text> component.`);
hostContext = nextReactTag;
nextReactTag += 2;
return {
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Renderer/implementations/ReactFabric-profiling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1948,7 +1948,7 @@ function createTextInstance(
internalInstanceHandle
) {
if (!hostContext.isInAParentText)
throw Error("Text strings must be rendered within a <Text> component.");
throw Error(`Text string "${text}" must be rendered within a <Text> component.`);
hostContext = nextReactTag;
nextReactTag += 2;
return {
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5258,7 +5258,7 @@ function createTextInstance(
internalInstanceHandle
) {
if (!hostContext.isInAParentText) {
throw new Error("Text strings must be rendered within a <Text> component.");
throw Error(`Text string "${text}" must be rendered within a <Text> component.`);
}

var tag = allocateTag();
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Renderer/implementations/ReactNativeRenderer-dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5095,7 +5095,7 @@ function createTextInstance(
internalInstanceHandle
) {
if (!hostContext.isInAParentText) {
throw Error("Text strings must be rendered within a <Text> component.");
throw Error(`Text string "${text}" must be rendered within a <Text> component.`);
}

var tag = allocateTag();
Expand Down