Extracted content of the case FunctionTypeAnnotation into emitFunction in parsers-primitives file #34950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on in parsers-orimitives file
facebook-github-bot
added
the
CLA Signed
Base commit: a885b1f |
Base commit: a885b1f |
cipolleschi
approved these changes
Oct 12, 2022
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @mohitcharkha in c403cd4. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
…n in parsers-primitives file (facebook#34950) Summary: This PR is part of facebook#34872 This PR extracts the content of the case `FunctionTypeAnnotation` into a single `emitFunction` function inside the parsers-primitives.js file and uses it in both Flow and TypeScript parsers ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extract the content of the case `FunctionTypeAnnotation` into a single `emitFunction` function Pull Request resolved: facebook#34950 Test Plan: Run yarn jest react-native-codegen and ensure CI is green <img width="984" alt="Screenshot 2022-10-12 at 11 18 54 AM" src="https://user-images.githubusercontent.com/86604753/195260414-136f918f-e4b7-4fcf-b0b9-9142872f3cf9.png"> Reviewed By: christophpurrer Differential Revision: D40296823 Pulled By: cipolleschi fbshipit-source-id: 3cac407d260481bd6ae7c3e46642e4c16bba3376
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…n in parsers-primitives file (facebook#34950) Summary: This PR is part of facebook#34872 This PR extracts the content of the case `FunctionTypeAnnotation` into a single `emitFunction` function inside the parsers-primitives.js file and uses it in both Flow and TypeScript parsers ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extract the content of the case `FunctionTypeAnnotation` into a single `emitFunction` function Pull Request resolved: facebook#34950 Test Plan: Run yarn jest react-native-codegen and ensure CI is green <img width="984" alt="Screenshot 2022-10-12 at 11 18 54 AM" src="https://user-images.githubusercontent.com/86604753/195260414-136f918f-e4b7-4fcf-b0b9-9142872f3cf9.png"> Reviewed By: christophpurrer Differential Revision: D40296823 Pulled By: cipolleschi fbshipit-source-id: 3cac407d260481bd6ae7c3e46642e4c16bba3376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of #34872
This PR extracts the content of the case
FunctionTypeAnnotationinto a singleemitFunctionfunction inside the parsers-primitives.js file and uses it in both Flow and TypeScript parsersChangelog
[Internal] [Changed] - Extract the content of the case
FunctionTypeAnnotationinto a singleemitFunctionfunctionTest Plan
Run yarn jest react-native-codegen and ensure CI is green
