Skip to content

[Codegen] Extract the buildSchema function in the parsers-commons.js #35158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[Codegen] Extract the buildSchema function in the parsers-commons.js #35158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4fe3dc9
refactor(parsers-commons-test): remove unused variables and imports
MaeIg Dec 14, 2022
6bf95dd
refactor(parser): extract getAst function in babel and flow parsers
MaeIg Dec 24, 2022
55ce578
feat(buildSchema): add non-shared functions in buildSchema params
MaeIg Dec 24, 2022
761c3eb
refactor(buildSchema): extract buildSchema in parsers-commons
MaeIg Dec 24, 2022
6991e4c
refactor(Visitor): rename the buildSchema file to Visitor
MaeIg Dec 24, 2022
6282ef8
type(Visitor): type Visitor return value
MaeIg Dec 24, 2022
a30678c
test(parsers-commons): add tests for buildSchema
MaeIg Dec 24, 2022
ec1d3d3
refactor(parsers): move buildSchemaFromConfigType from utils to parse…
MaeIg Dec 26, 2022
f575f2b
feat(parsers): don't duplicate buildSchema calls and use parseString …
MaeIg Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/eslint-plugin-specs/react-native-modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,11 @@ function rule(context) {

const {buildModuleSchema, createParserErrorCapturer, parser} =
requireModuleParser();
const flowParser = require('flow-parser');

const [parsingErrors, tryParse] = createParserErrorCapturer();

const sourceCode = context.getSourceCode().getText();
const ast = flowParser.parse(sourceCode, {enums: true});
const ast = parser.getAst(sourceCode);

tryParse(() => {
buildModuleSchema(hasteModuleName, ast, tryParse, parser);
Expand Down
Loading