chore: Add functionTypeAnnotation to codegen Parser class #36468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
the
Type: Enhancement
Base commit: 803bb16 |
rshest
approved these changes
Mar 14, 2023
Contributor
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…6468) Summary: This PR adds a `functionTypeAnnotation` function to the codegen Parser class and implements it in the Flow and TypeScript parsers as requested on facebook#34872, refactoring the `throwIfModuleTypeIsUnsupported` function to accept a `Parser` instead of a `ParserType` and use the newly created function instead of the `if (language)` logic. ## Changelog [Internal] [Added] - Add `functionTypeAnnotation` to codegen Parser class Pull Request resolved: facebook#36468 Test Plan: Run `yarn jest react-native-codegen` and ensure CI is green  Reviewed By: cipolleschi Differential Revision: D44056853 Pulled By: rshest fbshipit-source-id: f22b9efe53df16f7916eb1a9cea8b9531f1194f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
functionTypeAnnotationfunction to the codegen Parser class and implements it in the Flow and TypeScript parsers as requested on #34872, refactoring thethrowIfModuleTypeIsUnsupportedfunction to accept aParserinstead of aParserTypeand use the newly created function instead of theif (language)logic.Changelog
[Internal] [Added] - Add
functionTypeAnnotationto codegen Parser classTest Plan
Run
yarn jest react-native-codegenand ensure CI is green