Don't export private headers from Buck target #37127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
Base commit: 7e6f6aa |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: b5636def92f93abdabfced5243156723d778b18a
NickGerleman
force-pushed
the
export-D45339425
branch
from
a8c207b to
ee46d78
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: b12500c8a0c903ac1a8d9358b1449f8d527a91a5
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 556cabcea962666b06098eb845ad414527a3fef0
NickGerleman
force-pushed
the
export-D45339425
branch
from
ee46d78 to
b767f8c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 5c7aaf6c4e83ffe51ad1a59313eb5b518987a28e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 9996f0b0d02759eb6e7afd8469d2317471162378
NickGerleman
force-pushed
the
export-D45339425
branch
from
b767f8c to
5df47ea
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 9520d3b4e8d7ace9aa039379d60b58a1ae1278fc
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: e2c453e903c919dd9c6875208451295edc79a656
NickGerleman
force-pushed
the
export-D45339425
branch
from
5df47ea to
24a7475
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
force-pushed
the
export-D45339425
branch
from
24a7475 to
2a1dfd0
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 28, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: bdfbb4a3bc32bc005dbb639c5d7ab532ddd2c07a
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 28, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 29f1f31d15ea3f70bdca20ce5991e9f8c1fab4fe
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 29, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 61d9b442a9a16a409da37c7ad6d5fa1b58922de9
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 29, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 973984f8e9963a17cf9fefa5b024669ba9c6e9f7
NickGerleman
force-pushed
the
export-D45339425
branch
from
2a1dfd0 to
2ea0472
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
force-pushed
the
export-D45339425
branch
from
4fe6881 to
731425f
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 2, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 764517903b9b8ad1f55dded6d11d8388163f339e
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 2, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 8a156e55368b4a3e896d93f6b43ed05477c37e8c
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 2, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 59af51541ee952c831a81e7f2a37d53f88e2c5c7
NickGerleman
force-pushed
the
export-D45339425
branch
from
731425f to
4af113e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 2, 2023
Summary: Pull Request resolved: facebook#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 9a00c89c4d6ccfa33db7064c34b5cf5d400d58fe
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 2, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 630791a0fec1e4842c876151e3de3d6bec7bb9b9
NickGerleman
force-pushed
the
export-D45339425
branch
from
4af113e to
ab2b038
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 3, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: c338c44f8ac94c39ea61d3a9c210fad5a239d52a
NickGerleman
force-pushed
the
export-D45339425
branch
from
ab2b038 to
39433fc
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 3, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 30a23813bf756281d56b6078268194ba52fd3d4a
NickGerleman
force-pushed
the
export-D45339425
branch
from
39433fc to
809b5ac
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 3, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: a74f0b6e9bb575963c1af3d5adc513c53edc8d51
NickGerleman
force-pushed
the
export-D45339425
branch
from
809b5ac to
ab73eab
Compare
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: 5b2fd84c6d1e23d32c31a1c5c59775a829b758fd
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45339425 |
NickGerleman
force-pushed
the
export-D45339425
branch
from
ab73eab to
ef57f4f
Compare
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
May 3, 2023
Summary: Pull Request resolved: #1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: eb7ef151ad2467d7c3370cd7c10d47e8db9496a0
Contributor
|
This pull request has been merged in d5dad06. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
May 3, 2023
Summary: X-link: facebook/yoga#1269 X-link: facebook/react-native#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: eb7ef151ad2467d7c3370cd7c10d47e8db9496a0
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: X-link: facebook/yoga#1269 Pull Request resolved: facebook#37127 This prevents targets which include Yoga from using its private APIs. Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a `yoga-private-api` target for now to keep using these headers while making it unlikely new usages will show up. Reviewed By: javache Differential Revision: D45339425 fbshipit-source-id: eb7ef151ad2467d7c3370cd7c10d47e8db9496a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This prevents targets which include Yoga from using its private APIs.
Instances of this have been mostly cleaned up in the past diffs, with the major exception of RN Fabric. To stage this without blocking on that, I added a
yoga-private-apitarget for now to keep using these headers while making it unlikely new usages will show up.Reviewed By: javache
Differential Revision: D45339425