Skip to content

Conversation

@kyawthura-gg
Copy link
Contributor

Summary:

Part of #34872

[Codegen 110] Add a nullLiteralTypeAnnotation: string property into the Parser object and implement it in the FlowParser (returning
NullLiteralTypeAnnotation) and in the TypeScriptParser(returning TSNullKeyword). Replace them in the parsers/flow/components/events.js and parsers/typescript/components/events.js.

Changelog:

[Internal][Added]: Add nullLiteralTypeAnnotation property in Parser object

Test Plan:

yarn test react-native-codegen

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 11, 2023
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented May 11, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,732,593 +0
android hermes armeabi-v7a 8,043,923 -2
android hermes x86 9,221,938 -2
android hermes x86_64 9,074,913 +1
android jsc arm64-v8a 9,297,787 +1
android jsc armeabi-v7a 8,486,552 +0
android jsc x86 9,358,530 -2
android jsc x86_64 9,615,112 -1

Base commit: d8ced6f
Branch: main

@cipolleschi
Copy link
Contributor

/rebase

@github-actions github-actions bot force-pushed the fix/add-nullLiteralTypeAnnotation branch from 82a156d to 8916197 Compare May 15, 2023 12:26
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 17, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in b5c01ee.

@kyawthura-gg kyawthura-gg deleted the fix/add-nullLiteralTypeAnnotation branch May 19, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants