Skip to content

Conversation

@siddarthkay
Copy link
Contributor

Summary:

[Codegen 87] This PR introduces getProps to the Parser class and implements this function in Typescript and Flow Parsers.

We also get rid of the following files from :

  • packages/react-native-codegen/src/parsers/typescript/components/props.js
  • packages/react-native-codegen/src/parsers/flow/components/props.js

as requested on #34872

Changelog:

[Internal] [Changed] - Add getProps to Parsers and update usages.

Test Plan:

Run yarn jest react-native-codegen and ensure CI is green

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2023
@analysis-bot
Copy link

analysis-bot commented May 21, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,733,372 +0
android hermes armeabi-v7a 8,044,557 -1
android hermes x86 9,223,479 -1
android hermes x86_64 9,075,462 +1
android jsc arm64-v8a 9,298,180 -1
android jsc armeabi-v7a 8,486,915 +1
android jsc x86 9,359,348 -1
android jsc x86_64 9,615,424 -3

Base commit: 92c7219
Branch: main

@Pranav-yadav Pranav-yadav added the Tech: Codegen Related to react-native-codegen label May 22, 2023
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! We removed a couple of files from the codebase! 🎉

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

/rebase

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 25, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in fc927d1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Tech: Codegen Related to react-native-codegen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants