Skip to content

Add ExceptionsManagerModule for RNTester #40767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add ExceptionsManagerModule for RNTester #40767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .../react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/CoreReactPackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.facebook.react.module.model.ReactModuleInfoProvider;
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
import com.facebook.react.modules.core.DeviceEventManagerModule;
import com.facebook.react.modules.core.ExceptionsManagerModule;
import com.facebook.react.modules.debug.DevSettingsModule;
import com.facebook.react.modules.debug.SourceCodeModule;
import com.facebook.react.modules.deviceinfo.DeviceInfoModule;
Expand All @@ -36,6 +37,7 @@
SourceCodeModule.class,
LogBoxModule.class,
DeviceEventManagerModule.class,
ExceptionsManagerModule.class,
})
class CoreReactPackage extends TurboReactPackage {

Expand Down Expand Up @@ -63,6 +65,8 @@ public NativeModule getModule(String name, ReactApplicationContext reactContext)
return new DeviceEventManagerModule(reactContext, mHardwareBackBtnHandler);
case LogBoxModule.NAME:
return new LogBoxModule(reactContext, mDevSupportManager);
case ExceptionsManagerModule.NAME:
return new ExceptionsManagerModule(mDevSupportManager);
default:
throw new IllegalArgumentException(
"In BridgelessReactPackage, could not find Native module for " + name);
Expand All @@ -85,6 +89,7 @@ public ReactModuleInfoProvider getReactModuleInfoProvider() {
DevSettingsModule.class,
DeviceEventManagerModule.class,
LogBoxModule.class,
ExceptionsManagerModule.class,
};
final Map<String, ReactModuleInfo> reactModuleInfoMap = new HashMap<>();
for (Class<? extends NativeModule> moduleClass : moduleList) {
Expand Down
3 changes: 0 additions & 3 deletions packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ import com.facebook.soloader.SoLoader

class RNTesterApplication : Application(), ReactApplication {
override val reactNativeHost: ReactNativeHost by lazy {
if (ReactFeatureFlags.enableBridgelessArchitecture) {
throw RuntimeException("Should not use ReactNativeHost when Bridgeless enabled")
}
object : DefaultReactNativeHost(this) {
public override fun getJSMainModuleName(): String = BuildConfig.JS_MAIN_MODULE_NAME

Expand Down