Skip to content

Unhandled promise rejection - attach non-standard Error object stack info if possible #42079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Unhandled promise rejection - attach non-standard Error object stack info if possible #42079

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
341aa10
Try to attach non-standard error stack info
ospfranco Dec 27, 2023
2fa980f
Linting
ospfranco Dec 27, 2023
e5425ce
Linting
ospfranco Dec 27, 2023
24ae989
Types
ospfranco Dec 27, 2023
93b8228
Undo yarn changes
ospfranco Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/react-native/Libraries/promiseRejectionTrackingOptions.js
View file
Open in desktop
Copy link

@joe-sam joe-sam Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be mistaken but shouldn't the rejection.stack unwinding be done optimally before the final JSON.stringify((rejection: $FlowFixMe))?

Copy link
Contributor Author

@ospfranco ospfranco Dec 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think so, stringify does not unwind the stack or show it in the logbox . The stringify call is only for extracting a message.

Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ let rejectionTrackingOptions: $NonMaybeType<Parameters<enable>[0]> = {
? rejection
: JSON.stringify((rejection: $FlowFixMe));
}
// It could although this object is not a standard error, it still has stack information to unwind
// $FlowFixMe ignore types just check if stack is there
if (rejection.stack && typeof rejection.stack === 'string') {
stack = rejection.stack;
}
}

const warning = `Possible unhandled promise rejection (id: ${id}):\n${
Expand Down