Make [RCTBridge currentBridge] work also inBridgeless for backward compatibility. #42940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53575361 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Feb 9, 2024
…mpatibility. (facebook#42940) Summary: We might have some libraries that goes through the interop layer that are using [RCTBridge currentBridge]. Although this is an API that we would like them not to use, that's the sad reality and if we don't want to force a migration on those libraries, we need to be backward compatible. This diff sets the `RCTBridgeProxy` as the `currentBridge` in case the app is running in BridgelessMode. This should make Bridgeless backward compatible. ## Changelog [iOS][Fixed] - Make [RCTBridge currentBridge] work in bridgeless mode Reviewed By: RSNara Differential Revision: D53575361
cipolleschi
force-pushed
the
export-D53575361
branch
from
3b10599 to
111eb02
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53575361 |
Base commit: 7afc8b8 |
…mpatibility. (facebook#42940) Summary: We might have some libraries that goes through the interop layer that are using [RCTBridge currentBridge]. Although this is an API that we would like them not to use, that's the sad reality and if we don't want to force a migration on those libraries, we need to be backward compatible. This diff sets the `RCTBridgeProxy` as the `currentBridge` in case the app is running in BridgelessMode. This should make Bridgeless backward compatible. ## Changelog [iOS][Fixed] - Make [RCTBridge currentBridge] work in bridgeless mode Reviewed By: RSNara Differential Revision: D53575361
cipolleschi
force-pushed
the
export-D53575361
branch
from
111eb02 to
574c87d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D53575361 |
Contributor
|
This pull request has been merged in f6f4615. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We might have some libraries that goes through the interop layer that are using [RCTBridge currentBridge]. Although this is an API that we would like them not to use, that's the sad reality and if we don't want to force a migration on those libraries, we need to be backward compatible.
This diff sets the
RCTBridgeProxyas thecurrentBridgein case the app is running in BridgelessMode. This should make Bridgeless backward compatible.Changelog
[iOS][Fixed] - Make [RCTBridge currentBridge] work in bridgeless mode
Reviewed By: RSNara
Differential Revision: D53575361