Use npm as source of truth for updated packages (make publish script rerunnable) #42944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53607807 |
Base commit: b41a33e |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 12, 2024
…sh script rerunnable) (facebook#42944) Summary: Updates `find-and-publish-all-bumped-packages` to use the npm registry as the source of truth, similar to tools like Lerna (`lerna publish from-package`). **This enables safe reruns of the publish script**, and replaces the previous Git-diff-detection implementation. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D53607807
|
Sidenote: Why not use I'm aligning us closer towards this. The main gap right now is that we have custom behaviour around the |
…rerunnable) (facebook#42944) Summary: Updates `find-and-publish-all-bumped-packages` to use the npm registry as the source of truth, similar to tools like Lerna (`lerna publish from-package`). **This enables safe reruns of the publish script**, and replaces the previous Git-diff-detection implementation. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D53607807
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 12, 2024
…sh script rerunnable) (facebook#42944) Summary: Updates `find-and-publish-all-bumped-packages` to use the npm registry as the source of truth, similar to tools like Lerna (`lerna publish from-package`). **This enables safe reruns of the publish script**, and replaces the previous Git-diff-detection implementation. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D53607807
huntie
force-pushed
the
export-D53607807
branch
from
cfb6c17 to
41500eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53607807 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 12, 2024
…sh script rerunnable) (facebook#42944) Summary: Updates `find-and-publish-all-bumped-packages` to use the npm registry as the source of truth, similar to tools like Lerna (`lerna publish from-package`). **This enables safe reruns of the publish script**, and replaces the previous Git-diff-detection implementation. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D53607807
|
This pull request has been merged in 273a517. |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Feb 13, 2024
…rerunnable) (facebook#42944) Summary: Pull Request resolved: facebook#42944 Updates `find-and-publish-all-bumped-packages` to use the npm registry as the source of truth, similar to tools like Lerna (`lerna publish from-package`). **This enables safe reruns of the publish script**, and replaces the previous Git-diff-detection implementation. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D53607807 fbshipit-source-id: 135808b7ce36cf463c9f53a8059500b83f8b6679 # Conflicts: # scripts/monorepo/find-and-publish-all-bumped-packages.js
lunaleaps
pushed a commit
that referenced
this pull request
Feb 19, 2024
…2991) * Add Flow, add positive test case for monorepo publish step (#42936) Summary: Pull Request resolved: #42936 Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53607809 fbshipit-source-id: 990826fda5538af9a13e3f24978295a2f3b0c8c3 # Conflicts: # scripts/monorepo/__tests__/find-and-publish-all-bumped-packages-test.js # scripts/monorepo/find-and-publish-all-bumped-packages.js * Update exit cases for monorepo publish script (#42937) Summary: Pull Request resolved: #42937 Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53607810 fbshipit-source-id: 18e79f23060ee70e96bd8ac6e9995b0a8ba300b3 # Conflicts: # scripts/monorepo/__tests__/find-and-publish-all-bumped-packages-test.js # scripts/monorepo/find-and-publish-all-bumped-packages.js * Refactor package discovery in publish script (#42938) Summary: Pull Request resolved: #42938 Substitutes the `forEachPackage` util with a replacement async `getPackages` function. This will be used further in the next diff. The new function aims to be more erganomic/versatile than `forEachPackage` by returning a package mapping (see updated test mock). The API aligns roughly with `yarn workspaces list` and [Lerna's `detectProjects`](https://lerna.js.org/docs/api-reference/utilities#detectprojects). This also aligns with / replaces similar attempts in our existing scripts: - [`getPackagesToPublish`](https://github.com/facebook/react-native/blob/2ca7bec0c2a7d821ceaaf39840a6cdc5eceb8678/scripts/monorepo/get-and-update-packages.js#L56) - [`getPublicPackages`](https://github.com/facebook/react-native/blob/2ca7bec0c2a7d821ceaaf39840a6cdc5eceb8678/scripts/releases/set-version/index.js#L19) Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53607806 fbshipit-source-id: 00ec34edadab863dc8f2f0c7852f6e835a5dddf5 # Conflicts: # scripts/monorepo.js # scripts/monorepo/find-and-publish-all-bumped-packages.js # scripts/monorepo/for-each-package.js * Use npm as source of truth for updated packages (make publish script rerunnable) (#42944) Summary: Pull Request resolved: #42944 Updates `find-and-publish-all-bumped-packages` to use the npm registry as the source of truth, similar to tools like Lerna (`lerna publish from-package`). **This enables safe reruns of the publish script**, and replaces the previous Git-diff-detection implementation. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D53607807 fbshipit-source-id: 135808b7ce36cf463c9f53a8059500b83f8b6679 # Conflicts: # scripts/monorepo/find-and-publish-all-bumped-packages.js * Add retry to monorepo publish script (#42964) Summary: Pull Request resolved: #42964 We've seen npm publishes fail occasionally in CI as part of this script, most recently in S391653. This change adds a single retry, per package, during the execution of this script, in an attempt to reduce the chance of manual interventions after a broken pipeline. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53607808 fbshipit-source-id: 526d9c33d51ec57702efba3c199bad313c1bf2d4 # Conflicts: # scripts/monorepo/find-and-publish-all-bumped-packages.js * Rename and document monorepo publish script (#42989) Summary: Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53607805 fbshipit-source-id: babe9bbd7fb5e7016b567193727c6a441bee60a3 # Conflicts: # scripts/__tests__/publish-updated-packages-test.js # scripts/publish-updated-packages.js # scripts/releases-ci/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates
find-and-publish-all-bumped-packagesto use the npm registry as the source of truth, similar to tools like Lerna (lerna publish from-package). This enables safe reruns of the publish script, and replaces the previous Git-diff-detection implementation.Changelog: [Internal]
Differential Revision: D53607807