fix: build settings for custom build configuration #43780
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows build configuration named like `StagingDebug` to match with settings applied to `Debug` This fixes facebook#43185
facebook-github-bot
added
CLA Signed
cipolleschi
requested changes
Apr 2, 2024
Co-authored-by: Riccardo Cipolleschi <[email protected]>
cipolleschi
approved these changes
Apr 3, 2024
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in bcac3c4. |
cortinico
pushed a commit
that referenced
this pull request
Apr 8, 2024
Summary: This allows build configuration named like `StagingDebug` to match with settings applied to `Debug` This fixes #43185 Custom build setting were only applied to `Debug` build configurations, preventing configurations named `StagingDebug` or similar to access the new experimental debugger, as reported in #43185 This now applies the setting to every configuration ending with `Debug` ## Changelog: [IOS] [CHANGED] - fix: build settings for custom build configuration Pull Request resolved: #43780 Reviewed By: dmytrorykun Differential Revision: D55688996 Pulled By: cipolleschi fbshipit-source-id: 1f34cd722f6acfaa08d3377e19a04d08af97ed7c
This was referenced Apr 9, 2024
alfonsocj
pushed a commit
that referenced
this pull request
Apr 12, 2024
Summary: This allows build configuration named like `StagingDebug` to match with settings applied to `Debug` This fixes #43185 Custom build setting were only applied to `Debug` build configurations, preventing configurations named `StagingDebug` or similar to access the new experimental debugger, as reported in #43185 This now applies the setting to every configuration ending with `Debug` ## Changelog: [IOS] [CHANGED] - fix: build settings for custom build configuration Pull Request resolved: #43780 Reviewed By: dmytrorykun Differential Revision: D55688996 Pulled By: cipolleschi fbshipit-source-id: 1f34cd722f6acfaa08d3377e19a04d08af97ed7c
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Apr 22, 2024
Summary: This allows build configuration named like `StagingDebug` to match with settings applied to `Debug` This fixes facebook/react-native#43185 Custom build setting were only applied to `Debug` build configurations, preventing configurations named `StagingDebug` or similar to access the new experimental debugger, as reported in facebook/react-native#43185 This now applies the setting to every configuration ending with `Debug` ## Changelog: [IOS] [CHANGED] - fix: build settings for custom build configuration Pull Request resolved: facebook/react-native#43780 Reviewed By: dmytrorykun Differential Revision: D55688996 Pulled By: cipolleschi fbshipit-source-id: 1f34cd722f6acfaa08d3377e19a04d08af97ed7c
This was referenced May 10, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows build configuration named like
StagingDebugto match with settings applied toDebugThis fixes #43185Summary:
Custom build setting were only applied to
Debugbuild configurations, preventing configurations namedStagingDebugor similar to access the new experimental debugger, as reported in #43185This now applies the setting to every configuration ending with
DebugChangelog:
[IOS] [CHANGED] - fix: build settings for custom build configuration
Test Plan: