Improve profiling information for timers #45091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58832112 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58832112 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jun 20, 2024
Summary: Pull Request resolved: facebook#45091 Changelog: [internal] We're currently logging when we execute timers in Systrace/Perfetto, but we have no information about them whatsoever. This adds some additional information: * What kind of timer it is * It's ID * And most importantly, when it was created (including the ID as well). This allows us to know where was a specific timer scheduled and with what API. Differential Revision: D58832112
rubennorte
force-pushed
the
export-D58832112
branch
from
cb5e7e2 to
a0df93c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58832112 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jun 20, 2024
Summary: Pull Request resolved: facebook#45091 Changelog: [internal] We're currently logging when we execute timers in Systrace/Perfetto, but we have no information about them whatsoever. This adds some additional information: * What kind of timer it is * It's ID * And most importantly, when it was created (including the ID as well). This allows us to know where was a specific timer scheduled and with what API. Differential Revision: D58832112
rubennorte
force-pushed
the
export-D58832112
branch
from
a0df93c to
3fe6742
Compare
Base commit: 3dcf86b |
…using microtasks Differential Revision: D58816582
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58832112 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jun 21, 2024
Summary: Pull Request resolved: facebook#45091 Changelog: [internal] We're currently logging when we execute timers in Systrace/Perfetto, but we have no information about them whatsoever. This adds some additional information: * What kind of timer it is * It's ID * And most importantly, when it was created (including the ID as well). This allows us to know where was a specific timer scheduled and with what API. Reviewed By: bgirard Differential Revision: D58832112
rubennorte
force-pushed
the
export-D58832112
branch
from
3fe6742 to
5b64db5
Compare
Summary: Pull Request resolved: facebook#45091 Changelog: [internal] We're currently logging when we execute timers in Systrace/Perfetto, but we have no information about them whatsoever. This adds some additional information: * What kind of timer it is * It's ID * And most importantly, when it was created (including the ID as well). This allows us to know where was a specific timer scheduled and with what API. Reviewed By: bgirard Differential Revision: D58832112
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58832112 |
rubennorte
force-pushed
the
export-D58832112
branch
from
5b64db5 to
07449f7
Compare
Contributor
|
This pull request has been merged in a8a76f9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
We're currently logging when we execute timers in Systrace/Perfetto, but we have no information about them whatsoever.
This adds some additional information:
This allows us to know where was a specific timer scheduled and with what API.
Differential Revision: D58832112