chore(Android): convert systeminfo module classes to kotlin

[oddlyspaced]

Summary:

Saw a lot of PRs and push to convert existing Java code to Kotlin, and wanted to contribute to the cause. This is a starting point for me so I can understand more about the Java to Kotlin conversion process for ReactAndroid package.

Changelog:

• Converted AndroidInfoHelpers to Kotlin class
• Converted AndroidInfoModule to Kotlin object and updated usage of it across the package

Pick one each for the category and type tags:

[ANDROID] [CHANGED] - Migrated systeminfo module code from Java to Kotlin

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests

Test Plan:

Verified build on local dev environment.

[oddlyspaced]

Had to suppress the deprecation for SERIAL param in Android Info Module to get the package to compile. However in the Android docs it mentions now that the field is set to #UNKNOWN. Should I replace the Serial field with Unknown ?

https://developer.android.com/reference/android/os/Build#SERIAL

[javache]

Thanks for contributing here! We actually have a lot of tooling internally to help us do these migrations automatically, but we're doing them one module at a time, since it's easy for regressions to sneak in. This seems pretty safe though.

[oddlyspaced]

@javache I've added JvmStatic annotation to all the public methods of the object. Let me know if something else needs to be done from my end 👍🏾

[oddlyspaced]

@javache do let me know if something is remaining from my end 🙏

[oddlyspaced]

@javache sorry for the tag again, but anything that needs to be done by me ?

[facebook-github-bot]

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[oddlyspaced]

@javache Anything I need to do to fix these failing tests? 😓

[javache]

@javache Anything I need to do to fix these failing tests? 😓

Nope, I'm working on some internal build tooling but should be merged soon.

[facebook-github-bot]

@javache merged this pull request in 8dc2c90.

[react-native-bot]

This pull request was successfully merged by @oddlyspaced in 8dc2c90

^{When will my fix make it into a release? | How to file a pick request?}