Skip to content

Conversation

@Kudo
Copy link
Contributor

@Kudo Kudo commented Nov 27, 2024

Summary:

add a jest test to test when useColorScheme is not mocked. following up #47629 (comment)

Changelog:

[GENERAL] [ADDED] - Add useColorScheme mock test

Test Plan:

ci passed

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner labels Nov 27, 2024
@Kudo Kudo marked this pull request as ready for review November 27, 2024 18:56
@Kudo
Copy link
Contributor Author

Kudo commented Nov 27, 2024

@yungsters this is the following up pr for #47629 (comment). could you check whether the test makes sense to you?

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 27, 2024
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 28, 2024
@facebook-github-bot
Copy link
Contributor

@blakef merged this pull request in 24fee29.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Kudo in 24fee29

When will my fix make it into a release? | How to file a pick request?

@Kudo Kudo deleted the @kudo/use-color-scheme-mock-test branch November 28, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants