'[skip ci] [RN][Android] Move react-native-flags.cmake to ReactCommon #49745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70386742 |
|
This pull request was exported from Phabricator. Differential Revision: D70386742 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 3, 2025
Summary: Pull Request resolved: facebook#49745 It turns out we want those flags to be available also inside ReactCommon so I'm moving it there. This will allow us to reference them also inside ReactCommon and will make sure Common does not depend on Android Changelog: [Internal] [Changed] - Reviewed By: javache Differential Revision: D70386742
cortinico
force-pushed
the
export-D70386742
branch
from
7b55b3f to
0fc5d75
Compare
Summary: I'm adding the `target_compile_reactnative_options` to centralize the management of compilation flags for React Native CMake build. Changelog: [Internal] [Changed] - Differential Revision: D70386746
…droid targets Summary: Those targets inside ReactAndroid were not setting the compiler flags correctly for React Native. This change fixes them. Changelog: [Internal] [Changed] - Differential Revision: D70386747
…y libs Summary: Those 3rd party CMake libraries were not using our compiler flags correctly. This fixes it. Changelog: [Internal] [Changed] - Differential Revision: D70386743
|
This pull request was exported from Phabricator. Differential Revision: D70386742 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Mar 3, 2025
Summary: Pull Request resolved: facebook#49745 It turns out we want those flags to be available also inside ReactCommon so I'm moving it there. This will allow us to reference them also inside ReactCommon and will make sure Common does not depend on Android Changelog: [Internal] [Changed] - Reviewed By: javache Differential Revision: D70386742
cortinico
force-pushed
the
export-D70386742
branch
from
0fc5d75 to
6980fe7
Compare
Summary: Pull Request resolved: facebook#49745 It turns out we want those flags to be available also inside ReactCommon so I'm moving it there. This will allow us to reference them also inside ReactCommon and will make sure Common does not depend on Android Changelog: [Internal] [Changed] - Reviewed By: javache Differential Revision: D70386742
|
This pull request was exported from Phabricator. Differential Revision: D70386742 |
cortinico
force-pushed
the
export-D70386742
branch
from
6980fe7 to
92cdba6
Compare
|
This pull request has been merged in 5f0c857. |
ghost
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 29, 2025
Summary: Pull Request resolved: facebook#49745 It turns out we want those flags to be available also inside ReactCommon so I'm moving it there. This will allow us to reference them also inside ReactCommon and will make sure Common does not depend on Android Changelog: [Internal] [Changed] - Reviewed By: javache Differential Revision: D70386742 fbshipit-source-id: 3675c01f5e3f6515af6423d75e3fe145ba3d8936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It turns out we want those flags to be available also inside ReactCommon so I'''m moving it there.
This will allow us to reference them also inside ReactCommon and will make sure Common does not depend on Android
Changelog:
[Internal] [Changed] -
Differential Revision: D70386742