Skip to content

Conversation

huntie
Copy link
Member

@huntie huntie commented Apr 29, 2025

Summary:
Refactors our previous single-struct representation for PerformanceEntry (see MDN) as a std::variant — to precisely switch between the possible PerformanceEntry variations.

This maps closely to the PerformanceEntry type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Differential Revision: D73860532

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 29, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73860532

@huntie huntie force-pushed the export-D73860532 branch from 06a26a2 to 5c5e5ac Compare April 30, 2025 12:35
huntie added a commit to huntie/react-native that referenced this pull request Apr 30, 2025
Summary:

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Differential Revision: D73860532
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73860532

huntie added a commit to huntie/react-native that referenced this pull request Apr 30, 2025
Summary:

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Differential Revision: D73860532
huntie added a commit to huntie/react-native that referenced this pull request Apr 30, 2025
Summary:

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Differential Revision: D73860532
huntie added a commit to huntie/react-native that referenced this pull request Apr 30, 2025
Summary:

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Differential Revision: D73860532
@huntie huntie force-pushed the export-D73860532 branch from 5c5e5ac to 50e4f8c Compare May 1, 2025 09:15
huntie added a commit to huntie/react-native that referenced this pull request May 1, 2025
Summary:

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D73860532
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73860532

huntie added a commit to huntie/react-native that referenced this pull request May 1, 2025
Summary:

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D73860532
huntie added a commit to huntie/react-native that referenced this pull request May 1, 2025
Summary:

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D73860532
@huntie huntie force-pushed the export-D73860532 branch from 50e4f8c to 43229f3 Compare May 1, 2025 09:56
Summary:
Pull Request resolved: facebook#50995

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D73860532
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73860532

@huntie huntie force-pushed the export-D73860532 branch from 43229f3 to aa0138e Compare May 1, 2025 09:59
huntie added a commit to huntie/react-native that referenced this pull request May 1, 2025
Summary:

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Reviewed By: rshest

Differential Revision: D73860532
huntie added a commit to huntie/react-native that referenced this pull request May 1, 2025
Summary:

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Reviewed By: rubennorte, rshest

Differential Revision: D73860532
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 2, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1135f10.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @huntie in 1135f10

When will my fix make it into a release? | How to file a pick request?

ghost pushed a commit to discord/react-native that referenced this pull request Jul 29, 2025
Summary:
Pull Request resolved: facebook#50995

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Reviewed By: rubennorte, rshest

Differential Revision: D73860532

fbshipit-source-id: f3b7a7444d2456370620c1a1ba9a43f118cb9730
ghost pushed a commit to discord/react-native that referenced this pull request Jul 29, 2025
Summary:
Pull Request resolved: facebook#50995

Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`.

This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.

Changelog: [Internal]

Reviewed By: rubennorte, rshest

Differential Revision: D73860532

fbshipit-source-id: f3b7a7444d2456370620c1a1ba9a43f118cb9730
@huntie huntie deleted the export-D73860532 branch August 21, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants