Skip to content

Fixed borderBottomEndRadius on RTL #51229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fixed borderBottomEndRadius on RTL #51229

wants to merge 3 commits into from

Conversation

@riteshshukla04
Copy link
Contributor

@riteshshukla04 riteshshukla04 commented May 10, 2025 •
edited
Loading

Summary:

Fixes #51193

Changelog:

[ANDROID][FIXED] Wrong borderBottomEndRadius on RTL

Test Plan:

Tested with Arabic (RTL) and English(LTR)

English

Arabic

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels May 10, 2025
@riteshshukla04 riteshshukla04 force-pushed the main branch 2 times, most recently from 5c1062b to a7d15ed Compare May 10, 2025 07:56
@riteshshukla04
Copy link
Contributor Author

riteshshukla04 commented May 10, 2025

Test cases failing. Will fix

@YOEL311
Copy link

YOEL311 commented May 11, 2025 •
edited
Loading

@riteshshukla04
It makes sense that this issue is related to the BorderRadiusStyle.kt file, which doesn’t exist in version 0.74.
Since I only have access to compiled files locally, what’s the best way to check how changes in this file affect the behavior?

image

@riteshshukla04
Copy link
Contributor Author

riteshshukla04 commented May 11, 2025 •
edited
Loading

@YOEL311 You need to either build from source or use RNTester.
The changes in this PR will correct the issue but it would unfortunately break the test cases (which I dont have much time to fix at the moment ).

@YOEL311
Copy link

YOEL311 commented May 11, 2025

Thanks for your work
I will try to fix them

@YOEL311
Copy link

YOEL311 commented May 11, 2025

@riteshshukla04
I fixed the failed test
riteshshukla04#1

Please approve the PR

@riteshshukla04
Copy link
Contributor Author

riteshshukla04 commented May 12, 2025

Thanks @YOEL311 . I have opened the PR . Let the maintainers approve this

@YOEL311
Copy link

YOEL311 commented May 12, 2025 •
edited
Loading

@riteshshukla04
Will the fix be included in version 76, or only from version 80 and above?
And will there be a way to apply it manually to version 76?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 14, 2025

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

react-native-bot commented May 14, 2025

This pull request was successfully merged by @riteshshukla04 in 68d6ada

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 14, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 14, 2025

@NickGerleman merged this pull request in 68d6ada.

@YOEL311 YOEL311 mentioned this pull request May 14, 2025
Closed
This was referenced May 15, 2025
Closed
Closed
Closed
Closed
react-native-bot pushed a commit that referenced this pull request May 16, 2025
@riteshshukla04 @react-native-bot
Fixed borderBottomEndRadius on RTL (#51229)
af85c4c 
Summary:
Fixes #51193
## Changelog:
[ANDROID][FIXED] Wrong borderBottomEndRadius on RTL

Pull Request resolved: #51229

Test Plan:
Tested with Arabic (RTL) and English(LTR)

English
<img src="https://github.com/user-attachments/assets/5bd1eca9-194c-4d83-b75f-689bc13d827b" width=200>

Arabic
<img src="https://github.com/user-attachments/assets/459320a0-6bb2-4585-97bb-bd4ded6ec399" width=200>

Reviewed By: cortinico

Differential Revision: D74709219

Pulled By: NickGerleman

fbshipit-source-id: 885bb84d97d73324983d044fd2874a457b40f646
@react-native-bot
Copy link
Collaborator

react-native-bot commented May 16, 2025

This pull request was successfully merged by @riteshshukla04 in af85c4c

When will my fix make it into a release? | How to file a pick request?

cipolleschi pushed a commit that referenced this pull request Jun 4, 2025
@riteshshukla04 @cipolleschi
Fixed borderBottomEndRadius on RTL (#51229)
a47b9aa 
Summary:
Fixes #51193
[ANDROID][FIXED] Wrong borderBottomEndRadius on RTL

Pull Request resolved: #51229

Test Plan:
Tested with Arabic (RTL) and English(LTR)

English
<img src="https://github.com/user-attachments/assets/5bd1eca9-194c-4d83-b75f-689bc13d827b" width=200>

Arabic
<img src="https://github.com/user-attachments/assets/459320a0-6bb2-4585-97bb-bd4ded6ec399" width=200>

Reviewed By: cortinico

Differential Revision: D74709219

Pulled By: NickGerleman

fbshipit-source-id: 885bb84d97d73324983d044fd2874a457b40f646
@react-native-bot
Copy link
Collaborator

react-native-bot commented Jun 4, 2025

This pull request was successfully merged by @riteshshukla04 in a47b9aa

When will my fix make it into a release? | How to file a pick request?

@cipolleschi cipolleschi mentioned this pull request Jun 4, 2025
Merged
@cipolleschi cipolleschi mentioned this pull request Jun 16, 2025
Merged
cortinico pushed a commit that referenced this pull request Jul 1, 2025
@riteshshukla04 @cortinico
Fixed borderBottomEndRadius on RTL (#51229)
04fffa5 
Summary:
Fixes #51193
[ANDROID][FIXED] Wrong borderBottomEndRadius on RTL

Pull Request resolved: #51229

Test Plan:
Tested with Arabic (RTL) and English(LTR)

English
<img src="https://github.com/user-attachments/assets/5bd1eca9-194c-4d83-b75f-689bc13d827b" width=200>

Arabic
<img src="https://github.com/user-attachments/assets/459320a0-6bb2-4585-97bb-bd4ded6ec399" width=200>

Reviewed By: cortinico

Differential Revision: D74709219

Pulled By: NickGerleman

fbshipit-source-id: 885bb84d97d73324983d044fd2874a457b40f646
fabriziocucci pushed a commit that referenced this pull request Jul 9, 2025
@riteshshukla04 @fabriziocucci
Fixed borderBottomEndRadius on RTL (#51229)
6b2826e 
Summary:
Fixes #51193
[ANDROID][FIXED] Wrong borderBottomEndRadius on RTL

Pull Request resolved: #51229

Test Plan:
Tested with Arabic (RTL) and English(LTR)

English
<img src="https://github.com/user-attachments/assets/5bd1eca9-194c-4d83-b75f-689bc13d827b" width=200>

Arabic
<img src="https://github.com/user-attachments/assets/459320a0-6bb2-4585-97bb-bd4ded6ec399" width=200>

Reviewed By: cortinico

Differential Revision: D74709219

Pulled By: NickGerleman

fbshipit-source-id: 885bb84d97d73324983d044fd2874a457b40f646
@react-native-bot
Copy link
Collaborator

react-native-bot commented Jul 9, 2025

This pull request was successfully merged by @riteshshukla04 in 6b2826e

When will my fix make it into a release? | How to file a pick request?

@cipolleschi cipolleschi mentioned this pull request Oct 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

borderTopEndRadius and borderBottomEndRadius behave inconsistently on Android in RTL

4 participants

@riteshshukla04 @YOEL311 @facebook-github-bot @react-native-bot