fix: remove redundant if checks in traceMark #52756
Closed
+9
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There are some duplicated function calls in
PerformanceEntryReporter::reportMark(). I know this is a micro optimization but I feel this way the code is cleaner.This is called through
performance.markso there is potentially a tiny little performance improvement here?Changelog:
[INTERNAL] [FIXED] - Removed redundant checks in
PerformanceEntryReporter::reportMark()Test Plan:
The existing testing infrastructure should cover these callsites i believe