[Nav] Add support for bar button icons and left buttons #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NavigatorIOS supports four new properties:
- **rightButtonImageSource:** The source of an image to display in the top right. This must be a static image since UINavigationController only supports UIImages. Adding support for UIImageViews (or arbitrary views) is more complicated because custom views do not fade on touch and do not have hit slop the same way that UIImage buttons do. Usage: `rightButtonImageSource: ix('ImageName')`
- **backButtonImageSource:** Use a custom image for the back button. This does not replace the back caret (`<`) but instead replaces the text next to it.
- **leftButtonTitle**: Text for the left nav button, which supersedes the previous nav item's back button when specified. The main use case for this is your initial screen/UIVC which has nothing to go back to (since it is the first VC on the stack) but need to display a left button. This does hide the back button if there would have been one otherwise.
- **leftButtonImageSource:** Image source for the left button, supersedes the left button title.
Added UIExplorer example to demonstrate.
arasmussen
force-pushed
the
master
branch
5 times, most recently
from
9b61be2 to
41453a5
Compare
|
Superseded by #263 |
harrykiselev
pushed a commit
to harrykiselev/react-native
that referenced
this pull request
Aug 5, 2015
Update link to TodoMVC tutorial in README
acoates-ms
pushed a commit
to acoates-ms/react-native
that referenced
this pull request
Jun 10, 2019
facebook#81) * Adding back the Accessibility Actions that were mistakenly remove in the last merge - RN57 * Add back performAccessibilityAction that was accidentaly removed during merge on RN57 * Adding More methods removed during last Merge on RN57
This was referenced Sep 12, 2021
react-one
pushed a commit
to react-one/react-native
that referenced
this pull request
Sep 24, 2021
SudoPlz
pushed a commit
to SudoPlz/react-native
that referenced
this pull request
Jul 22, 2025
…facebook#51856) (facebook#81) Summary: Pull Request resolved: facebook#51856 Enables the `enableEagerAlternateStateNodeCleanup` feature flag in the open source React Native renderers that are currently targeting React 19.1, by manually patching them in the React Native repository. This feature flag has been found to significantly improve memory management of parent alternate fibers in persistent modes (i.e. Fabric), and we want this to be available to open source users of React Native before the next scheduled public version release of React. For more details about the fix, see: facebook/react#33161 Changelog: [General][Changed] - Reduces memory usage, by improving memory management of parent alternate fibers. (Previously, a parent fiber might retain memory associated with shadow nodes from a previous commit.) Reviewed By: rickhanlonii Differential Revision: D76073900 fbshipit-source-id: 6779ea0862d4a1e25354b12ef3d1363dc12d26cc Co-authored-by: Tim Yung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavigatorIOS supports four new properties:
rightButtonImageSource: ix('ImageName')<) but instead replaces the text next to it.Added UIExplorer example to demonstrate.