Skip to content

Cherry-pick: Fix Navigation Links #8703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2016
Merged

Cherry-pick: Fix Navigation Links #8703

merged 2 commits into from
Jul 12, 2016

Conversation

@JoelMarcey
Copy link

@JoelMarcey JoelMarcey commented Jul 12, 2016

See: b33424e.

We also need 7d3fbbd since it is a prerequisite to b33424e.

Test Plan:

http://localhost:8079/react-native/docs/using-navigators.html

Links work.

hramos added 2 commits July 11, 2016 20:05
@hramos @JoelMarcey
Introduce navigators in the tutorial
32b963b 
Summary:
Adds a new section to the tutorial. Covers the basics of scenes and navigators.

The navigator comparison doc has been moved to docs/navigation.html in this PR.

![navigators](https://cloud.githubusercontent.com/assets/165856/16505919/37459e3a-3ed4-11e6-87e9-5fa7e6f792d3.png)
Closes #8515

Differential Revision: D3507325

Pulled By: caabernathy

fbshipit-source-id: e9ee5b2572868189af198cdf461b2728dfa84f9e
@hramos @JoelMarcey
Fix links from networking to navigation in The Basics.
3f27bfc 
Summary:
Fixes #8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.
Closes #8698

Differential Revision: D3544388

Pulled By: JoelMarcey

fbshipit-source-id: d5132b112e3079d1fd9ab6d84ff1a4328bee871f
@ghost
Copy link

ghost commented Jul 12, 2016

By analyzing the blame information on this pull request, we identified @hramos and @vjeux to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 12, 2016
@bestander
Copy link
Contributor

bestander commented Jul 12, 2016

LGTM, should be safe to merge.
@JoelMarcey, we have already cut branch 30, with the release next week this docs will be lost unless you cherry-pick this to 0.30-stable

@bestander bestander merged commit eb55b99 into facebook:0.29-stable Jul 12, 2016
@JoelMarcey JoelMarcey mentioned this pull request Jul 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hramos hramos

@bestander bestander

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoelMarcey @bestander @hramos