Skip to content

Fix typo in image documentation #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix typo in image documentation #970

wants to merge 1 commit into from

Conversation

@premasagar
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2015
sahrens
sahrens reviewed Apr 22, 2015
View reviewed changes
Libraries/Image/Image.ios.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amasad / @frantic: when are we going to update documentation and examples for the new relative path hotness? Would be good to do it earlier rather than later to reduce the amount of legacy people build up in their apps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, but let's test it internally first. I'd say in a week or so. We should still support using images that are managed by Xcode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahrens - can you give an example of the new relative path hotness?

@a2 a2 closed this in 33ac55b May 21, 2015
ayushjainrksh pushed a commit to MLH-Fellowship/react-native that referenced this pull request Jul 2, 2020
@cpojer
Add the "optimizing-flatlist-configuration" topic (facebook#970)
11cada2 
* Add the "optimizing-flatlist-configuration" topic

* Update en.json

* Add Props

* Add List items tips

* Update optimizing-flatlist-configuration.md

* Add version 0.60

* Update versions.json

* Remove version-0.60

* Create version-0.60-RC-optimizing-flatlist-configuration
This was referenced Mar 28, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@ebarahona ebarahona mentioned this pull request Jun 20, 2023
Open
@bumplzz69 bumplzz69 mentioned this pull request Jun 20, 2023
Open
@joseroubert08 joseroubert08 mentioned this pull request Jun 21, 2023
Open
@enterstudio enterstudio mentioned this pull request Jun 21, 2023
Open
@caschomburg123 caschomburg123 mentioned this pull request Jun 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@amasad amasad

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@premasagar @facebook-github-bot @frantic @sahrens @amasad @reactjs-bot